From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9397BC433F5 for ; Tue, 24 May 2022 16:59:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 237348D0005; Tue, 24 May 2022 12:59:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E6778D0001; Tue, 24 May 2022 12:59:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AC9B8D0005; Tue, 24 May 2022 12:59:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F130E8D0001 for ; Tue, 24 May 2022 12:59:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id C711D80645 for ; Tue, 24 May 2022 16:59:21 +0000 (UTC) X-FDA: 79501247322.24.971A57F Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by imf03.hostedemail.com (Postfix) with ESMTP id B0A2520025 for ; Tue, 24 May 2022 16:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653411561; x=1684947561; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=G8zqKzbAC43VBmVdOb+NPWZaQn7ZOrqgIiOJCocAtuM=; b=axSJ7zCrsv2G59ZzuaEqD9hk/VNipocDwbQ5SqSkJZOl9/pxDz1Kgn22 CA6Ko39wBX6//vKu0T9gh4nfGcPHGkFAhFX9JFRwK1rZsa8buqRt7eoS9 rireLt0yjtGsQB94LwhJtgYsWo+XSSvmmaxAv2kaDKK+Sk7BVUlodja7e M=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-02.qualcomm.com with ESMTP; 24 May 2022 09:59:19 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 09:59:19 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 09:59:19 -0700 Received: from qian (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 09:59:17 -0700 Date: Tue, 24 May 2022 12:59:15 -0400 From: Qian Cai To: Zi Yan CC: David Hildenbrand , , , , Vlastimil Babka , Mel Gorman , Eric Ren , Mike Rapoport , "Oscar Salvador" , Christophe Leroy , Andrew Morton Subject: Re: [PATCH v11 0/6] Use pageblock_order for cma and alloc_contig_range alignment. Message-ID: References: <0E75B247-8150-48A3-83AE-56C586030006@nvidia.com> <48D48FDC-B8DD-41C9-B56A-EBD7314883AB@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B0A2520025 X-Stat-Signature: 44wgpceea74jussw4x9gk9jburp1sjq6 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=axSJ7zCr; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf03.hostedemail.com: domain of quic_qiancai@quicinc.com designates 199.106.114.39 as permitted sender) smtp.mailfrom=quic_qiancai@quicinc.com X-HE-Tag: 1653411548-581185 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 22, 2022 at 12:54:04PM -0400, Zi Yan wrote: > Can you try the patch below on top of linux-next to see if it fixes the infinite loop issue? > Thanks. > > 1. split_free_page() change is irrelevant but to make the code more robust. > 2. using set_migratetype_isolate() in isolate_single_pageblock() is to properly mark the pageblock > MIGRATE_ISOLATE. > 3. setting to-be-migrated page's pageblock to MIGRATE_ISOLATE is to avoid a possible race > that another thread might take the free page after migration. > 4. off-by-one fix and no retry if free page is not found after migration like I added before. Cool. I'll be running it this week and report back next week.