From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B5B1C433EF for ; Tue, 24 May 2022 19:44:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDF6B8D0003; Tue, 24 May 2022 15:44:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8B318D0002; Tue, 24 May 2022 15:44:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A29E38D0003; Tue, 24 May 2022 15:44:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8EB0B8D0002 for ; Tue, 24 May 2022 15:44:05 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 5C6B08092C for ; Tue, 24 May 2022 19:44:05 +0000 (UTC) X-FDA: 79501662450.12.41C2EB8 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf09.hostedemail.com (Postfix) with ESMTP id 3946E140027 for ; Tue, 24 May 2022 19:43:52 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id p63so1631144qkf.0 for ; Tue, 24 May 2022 12:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=duLuqB8eb+MaAuTUNyV5BqcfLXI7fybo56wYzXWGIiA=; b=LQjPgH5pYVk+OZLBC5c+2LKzzjOPpoPsmIYf3dAjs7IR7wior+HPhi5DLXc2LN8Drl EoPOpIeoYB26pjGvRbHNNSnA83STJMvJOYq7RdgglpVduRGUsjLWU10mtO5H62JaXoF9 vvdrZTi3UEoCva9nzg8aa+ette30RLNnKvAt1D0z2fJD1n7xhSZUHFvUzyk1gsVM0VGu pEoEpUMwmqNqgZVw0lPpHwqwyrHiZd6uvBB/uBLURbI24NimfrzoT/Ih/EthYiIFc3u+ zvk+RxOEcP5uiATSRbIUpyJOVEjk6lS5kjo/wf6G+dhdXufA7bCE4Qi4FA0Ug0L+2n1p CCJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=duLuqB8eb+MaAuTUNyV5BqcfLXI7fybo56wYzXWGIiA=; b=uS4XNBF6LXSoykisKELIB27K/td3MYR+4ACLujgXIad2Gh1m4N3CxOa0SyASkcS9Aw eXdJGlrdEmQVNCDkiuHcViT0eliBFER5Rb077wQAEfLmJjRm27OXNyWapgM7Mix+19z0 kX/d0Q5VfnPZrytDx2g6WtKUhHxHjyQGDUsJ/DakRSae6jxE5Fz2X1K6488xwnltxj6I uAuElGwkZ+2wV1Pcga3Ib69YR9/D0IN+KEEa+ClwIGYeqD3znZaoH+SDa/jp7EDdxges MzGDs3ws2xEjfnGorIaH5ja2t4VwR3mJJVhGHC1v5TjlLNL7ghTO387qyamq2oS2TdT7 ECBg== X-Gm-Message-State: AOAM532GO/2Xv4rWxPO6dzH/vCTWccVJVwxAPBkku/2dCd28VEdIXJRr V017glstkKRyfL2UUPVZAcIqAQ== X-Google-Smtp-Source: ABdhPJwTajcKtx2V/QLGvqEuTqKhR5BiouYc6FC4OWgv+ME5gp4jMrmzVH3N6vonhgCQHelCZJf3bQ== X-Received: by 2002:a05:620a:408f:b0:6a0:4fda:b4c9 with SMTP id f15-20020a05620a408f00b006a04fdab4c9mr18131976qko.777.1653421443943; Tue, 24 May 2022 12:44:03 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:741f]) by smtp.gmail.com with ESMTPSA id r7-20020ac87947000000b002f3fbf28826sm149560qtt.23.2022.05.24.12.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 12:44:03 -0700 (PDT) Date: Tue, 24 May 2022 15:44:02 -0400 From: Johannes Weiner To: Muchun Song Cc: mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v4 10/11] mm: lru: add VM_BUG_ON_FOLIO to lru maintenance function Message-ID: References: <20220524060551.80037-1-songmuchun@bytedance.com> <20220524060551.80037-11-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524060551.80037-11-songmuchun@bytedance.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3946E140027 X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=LQjPgH5p; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Stat-Signature: zkggr9pz68mqxmwbk9618mb7xrs485rq X-HE-Tag: 1653421432-440692 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 02:05:50PM +0800, Muchun Song wrote: > We need to make sure that the page is deleted from or added to the > correct lruvec list. So add a VM_BUG_ON_FOLIO() to catch invalid > users. > > Signed-off-by: Muchun Song Makes sense, but please use VM_WARN_ON_ONCE_FOLIO() so the machine can continue limping along for extracting debug information.