From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D4AC433F5 for ; Wed, 11 May 2022 23:15:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 948836B0073; Wed, 11 May 2022 19:15:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F7636B0075; Wed, 11 May 2022 19:15:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 797A56B0078; Wed, 11 May 2022 19:15:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6BF4E6B0073 for ; Wed, 11 May 2022 19:15:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 457A561F8B for ; Wed, 11 May 2022 23:15:21 +0000 (UTC) X-FDA: 79455020442.09.ED9C9B3 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf30.hostedemail.com (Postfix) with ESMTP id 3D51B800B1 for ; Wed, 11 May 2022 23:15:02 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id cu23-20020a17090afa9700b001d98d8e53b7so4896133pjb.0 for ; Wed, 11 May 2022 16:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m2PZ7/ergchDUvDU1q/dXdJquLBZCPQq2ci7Ijk/I3o=; b=M4QjA4SkWhdKZ4VkoGA74I2zNJd01CKQqCeov3Rkl/dmflAQtAHHVHBQnwwB9rFKXX U6Z3nkjmpZnQr/91j8VdrH45ohKSPdMwKq6BhiC6VP6/GD3BXg/9AfpT1WgRO7kjj93M rOhelHLMXeiJZKg/tO1XJtQGbatXB7evVCU9CyU93gg19rIKiAR5DZp9mJnnq8sqS1Cq c3zHvjYOhujXQ+RHgpVVn3z/kV6dK26AJIPkolYP2xVoEaI7FS98EWVekkpCihlIE1lW ledrjajj/M1I29UdJHCEqgB31G87bTYP0JEMnWC3CGtJCEtCi3FtdhSwpeRepgtfV9p7 Co7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=m2PZ7/ergchDUvDU1q/dXdJquLBZCPQq2ci7Ijk/I3o=; b=eqbaVyjpOkspQbgZbRqc/cpq9V1r1rWMHJwgbmqA0RRFMNDGNTqJJMrK/shuecYXFi uMy7MU8GbIXGW4s1WKXQRtdddrwvQc0XOXfiaoYB0AFfOYwLcZ2hFItWYJadjnTTC9rF 3LD2RBm1F7Z4ZZ0VIZn/aT6oLfF8ZTibQKUUdqQQ7XcUZ46vv6hAdbBIIi879d7CXJjr GRmrcrqVAO14o0hHNZuHuXPnKFTiKnFX5A5NH29nTSg5SFlmcV7w+Wtf3NOYSsJ1jUaY xicRGeS6Wn6lxKAcXwcDIpWcy4J0aBqgnIxyXNjRNzSd2E0Syl5WzkzdDuhXjOMfvdtN TLsA== X-Gm-Message-State: AOAM532hGOkssSKLZy7VjzrQqa/UzRT+jBIJl4r7Vp58KWsFY5oq0VhR lcyS+t5AgMoTCHi5JHKKrPc= X-Google-Smtp-Source: ABdhPJyNqumh4+qTIEHzWQXH0hRJocp+/otL3WWip/bkqkQSkvQunCDy6QkojaGAb5hPjyW96ejSNw== X-Received: by 2002:a17:90b:17c5:b0:1dc:e0a6:340b with SMTP id me5-20020a17090b17c500b001dce0a6340bmr7816101pjb.34.1652310919815; Wed, 11 May 2022 16:15:19 -0700 (PDT) Received: from google.com ([2620:15c:211:201:69ef:9c87:7816:4f74]) by smtp.gmail.com with ESMTPSA id c5-20020a170902b68500b0015f0dcd1579sm2498181pls.9.2022.05.11.16.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 16:15:19 -0700 (PDT) Date: Wed, 11 May 2022 16:15:17 -0700 From: Minchan Kim To: John Hubbard Cc: Andrew Morton , linux-mm , LKML , "Paul E . McKenney" , John Dias , David Hildenbrand Subject: Re: [PATCH v4] mm: fix is_pinnable_page against on cma page Message-ID: References: <2ffa7670-04ea-bb28-28f8-93a9b9eea7e8@nvidia.com> <54b5d177-f2f4-cef2-3a68-cd3b0b276f86@nvidia.com> <8f083802-7ab0-15ec-b37d-bc9471eea0b1@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f083802-7ab0-15ec-b37d-bc9471eea0b1@nvidia.com> X-Rspamd-Queue-Id: 3D51B800B1 X-Stat-Signature: oo83obtr6z6p11qys39jbyqh8dzj9owp X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=M4QjA4Sk; spf=pass (imf30.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam09 X-HE-Tag: 1652310902-327577 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 11, 2022 at 04:13:10PM -0700, John Hubbard wrote: > On 5/11/22 16:08, Minchan Kim wrote: > > > OK, so the code checks the wrong item each time. But the code really > > > only needs to know "is either _CMA or _ISOLATE set?". And so you > > > > Yes. > > > > > can just sidestep the entire question by writing it like this: > > > > > > int mt = get_pageblock_migratetype(page); > > > > > > if (mt & (MIGRATE_ISOLATE | MIGRATE_CMA)) > > > return false; > > > > I am confused. Isn't it same question? > > > > set_pageblock_migratetype(MIGRATE_ISOLATE) > > if (get_pageblock_migrate(page) & MIGRATE_CMA) > > > > set_pageblock_migratetype(MIGRATE_CMA) > > > > if (get_pageblock_migrate(page) & MIGRATE_ISOLATE) > > Well no, because the "&" operation is a single operation on the CPU, and > isn't going to get split up like that. Oh, if that's true, yeah, I could live with it. Thanks, let me post next revision with commenting about that.