From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A64C433EF for ; Wed, 11 May 2022 23:12:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A3406B0075; Wed, 11 May 2022 19:12:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 551C66B0078; Wed, 11 May 2022 19:12:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F2E66B007B; Wed, 11 May 2022 19:12:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 31E8A6B0075 for ; Wed, 11 May 2022 19:12:05 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F0CCA30BE7 for ; Wed, 11 May 2022 23:12:04 +0000 (UTC) X-FDA: 79455012168.27.1239BF8 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf07.hostedemail.com (Postfix) with ESMTP id 3E973400A2 for ; Wed, 11 May 2022 23:11:58 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id e24so3581503pjt.2 for ; Wed, 11 May 2022 16:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DUv1H+jnNS72Cgs6yWB8Bi4tP13NzB8jjCDndTMF8+I=; b=ppRcsj/P3i32cgR8EG+vZChJ1appBXU+gsRrT8INVOuTHoH0T17uZQGgBU8Z7CuFVy p+btZOQmIHix89dfdK92O9EHk7kAEXx+PLEIdebzhxotbS4PgpbsFWfuzILzkS18nNBM bgaMefBjyKX7nWiEKh2dXhYhlXa+JX3RdaKyt3L/mUtkU96o5weFRYiS2w+O7bjQEJLQ rf2oUOkifcQNf9UW55kUV6N3LjZTKN5Ij8rtyv7no05tZKBdHqIpdJgppauwvRBmzWjY me07CdCskRiIXSVzpQD174k/w5mwCqOfTllJooXzLWIktu6StDYMkUTW6ZeSPUo1Sz3Y upcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=DUv1H+jnNS72Cgs6yWB8Bi4tP13NzB8jjCDndTMF8+I=; b=vktupz2cdU5oz1xOrkS5NQxSxFOG4PVlAn9owyfSGAK6sGZjgsguGm2Lz4Uz059s1m 6GIaDiMJvX7AisJXl4DWb3IAEz0B9c3hL6bFujA7Tzn/vHu0ji1BPDFybSnG1G7IwCG2 Qoaiagjx8ySs9sm8DnvYWjuC3SDehAKUrxgo9MRmAqzo9Y7VMuAu90G9DEP4TK7h4coa Yw+Zb8z91g/WzpwQZpUdqq3UJELlqSZY6EhFjaEg9x+I4Ih7QHYPXS8Xvx1DSPVCui6/ S+a1ZD/EwsA1OekMpu91t3Yo84rpibkGk2aL9y/dSNBY+gRvpD4czhHDyIVCulo9g8Tk GgAw== X-Gm-Message-State: AOAM5316bmSWUmSPvmmsm9MluZ6+Z0I8LJm+9+VozYmmszZ8aK+8hQIK //nz5WbOFp9iCFgd911l7zE= X-Google-Smtp-Source: ABdhPJzhteElceeuVnZQP9OEuRFPtKDfFPM3glDSUQV0jCZR41svwcddTJF5MNrHenx3XEiEP+5xQA== X-Received: by 2002:a17:903:1252:b0:154:ca85:59a0 with SMTP id u18-20020a170903125200b00154ca8559a0mr27746614plh.169.1652310723575; Wed, 11 May 2022 16:12:03 -0700 (PDT) Received: from google.com ([2620:15c:211:201:69ef:9c87:7816:4f74]) by smtp.gmail.com with ESMTPSA id b9-20020a170902d50900b0015e8d4eb2e3sm2491273plg.301.2022.05.11.16.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 16:12:03 -0700 (PDT) Date: Wed, 11 May 2022 16:12:01 -0700 From: Minchan Kim To: Andrew Morton Cc: Sultan Alsawaf , stable@vger.kernel.org, Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zsmalloc: Fix races between asynchronous zspage free and page migration Message-ID: References: <20220509024703.243847-1-sultan@kerneltoast.com> <20220511134322.54c44cb0cdd17a0f7fd9f761@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220511134322.54c44cb0cdd17a0f7fd9f761@linux-foundation.org> X-Stat-Signature: yax8k7jkanti48bbq83ty7ezrsyyaom9 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="ppRcsj/P"; spf=pass (imf07.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3E973400A2 X-HE-Tag: 1652310718-407822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 11, 2022 at 01:43:22PM -0700, Andrew Morton wrote: > On Wed, 11 May 2022 12:50:20 -0700 Sultan Alsawaf wrote: > > > > Shouldn't the fix be Fixes: 77ff465799c6 ("zsmalloc: zs_page_migrate: skip > > > unnecessary loops but not return -EBUSY if zspage is not inuse)? > > > Because we didn't migrate ZS_EMPTY pages before. > > > > Hi, > > > > Yeah, 77ff465799c6 indeed seems like the commit that introduced the bug. > > I updated the changelog, thanks. Thanhks, Andrew. Feel free to include my Acked-by: Minchan Kim