From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDA3C433F5 for ; Wed, 11 May 2022 09:13:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED4C96B0073; Wed, 11 May 2022 05:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E85316B0075; Wed, 11 May 2022 05:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4BC86B0078; Wed, 11 May 2022 05:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C383B6B0073 for ; Wed, 11 May 2022 05:13:07 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9A9FE61608 for ; Wed, 11 May 2022 09:13:07 +0000 (UTC) X-FDA: 79452898014.01.6394840 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf03.hostedemail.com (Postfix) with ESMTP id B559A20098 for ; Wed, 11 May 2022 09:12:58 +0000 (UTC) Received: from zn.tnic (p5de8eeb4.dip0.t-ipconnect.de [93.232.238.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 408B51EC053F; Wed, 11 May 2022 11:13:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1652260381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Rl96LlwUayMVLB9Ox0K7EFk+HS7SAZNt7K1olPYN8Qo=; b=Duquyg3rKjp+y7ODQUAjIdw8MyLoXi0PtGqN9Uvp4Q6iFjDWDtrtKTTdeGNAvniLJ9Yglw 25CwXIBrlMwP35/M1L3iIu0onVeccf45hNzVh0tgHL+95xHX3ecuBTMkr6TQyNcv+z2bui rRAljZNtex98qUrJvHyAQ1/s7zMfbAk= Date: Wed, 11 May 2022 11:13:08 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: "Kirill A. Shutemov" , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Dave Hansen , Brijesh Singh , Mike Rapoport , David Hildenbrand , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv5 10/12] x86/tdx: Unaccepted memory support Message-ID: References: <20220425033934.68551-1-kirill.shutemov@linux.intel.com> <20220425033934.68551-11-kirill.shutemov@linux.intel.com> <20220506204423.gu6jrb53kmuxze5r@box.shutemov.name> <20220511011906.el4m54fns7ilh7fr@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220511011906.el4m54fns7ilh7fr@box.shutemov.name> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B559A20098 X-Stat-Signature: 9s89pwte7b1a1ni8ta7hffrqk78z4ejg Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=Duquyg3r; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de X-HE-Tag: 1652260378-167637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 11, 2022 at 04:19:06AM +0300, Kirill A. Shutemov wrote: > JFYI, I've reworked it as > > accepted = try_accept_one(start, len, PG_LEVEL_1G); > if (!accepted) > accepted = try_accept_one(start, len, PG_LEVEL_2M); > if (!accepted) > accepted = try_accept_one(start, len, PG_LEVEL_4K); > if (!accepted) > return false; > start += accepted; s/accepted/accpt_size/ and then it is perfectly clear what that variable contains. But it seems you're preparing a new version so I'll continue looking at there. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette