From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12090C433FE for ; Tue, 10 May 2022 05:46:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 830736B0072; Tue, 10 May 2022 01:46:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E19E6B0073; Tue, 10 May 2022 01:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A9396B0074; Tue, 10 May 2022 01:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5C5966B0072 for ; Tue, 10 May 2022 01:46:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 2A47960855 for ; Tue, 10 May 2022 05:46:02 +0000 (UTC) X-FDA: 79448747364.27.A1FF7DE Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id E27BE800A0 for ; Tue, 10 May 2022 05:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cpwq/OLvQ6BxCOaH+3pF5HdK307ERk7HHWVvMWH/28U=; b=MpMWT1FEZcXAuLHYaX7QGm59Fe +Xe4NR2djbwqu6Z34ULgu3zfo19+scTn4YJGLz7OrHl70yFbLc56gH4uX64lbATYoPth+p+eUitQV 4XmoTeHkzSxmuwpgLfUhlGBbOYtGZWPmrDznB0zthU+q82QSko6oxaSAfwaDdqEMRdu7fC8mTlvor wdXIQKyKGuHGs5dZQp+E+XUMylRxGPsxegf4X0pcAPtE/zjU6m2ywUhMa/I1lQ3zD3KcTxwhttMb/ WXwuLCw1qiAsRzlJN0vuMF+jIoIUgI9TSodb3Mi3NRWvvNtsrAzV04GtThZUoZLNp18BERtMniMd/ oefUel2Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1noIgo-00034j-FN; Tue, 10 May 2022 05:45:42 +0000 Date: Mon, 9 May 2022 22:45:42 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com, rgoldwyn@suse.de, viro@zeniv.linux.org.uk, willy@infradead.org, naoya.horiguchi@nec.com, linmiaohe@huawei.com Subject: Re: [PATCH v11 06/07] xfs: support CoW in fsdax mode Message-ID: References: <20220508143620.1775214-1-ruansy.fnst@fujitsu.com> <20220508143620.1775214-14-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220508143620.1775214-14-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E27BE800A0 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=MpMWT1FE; spf=none (imf30.hostedemail.com: domain of BATV+237a309e1dc5667e2ea1+6834+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+237a309e1dc5667e2ea1+6834+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: ewk4si9ohkb48jt8iwd9uwnxss9ttye6 X-HE-Tag: 1652161543-59415 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +#ifdef CONFIG_FS_DAX > +int > +xfs_dax_fault( > + struct vm_fault *vmf, > + enum page_entry_size pe_size, > + bool write_fault, > + pfn_t *pfn) > +{ > + return dax_iomap_fault(vmf, pe_size, pfn, NULL, > + (write_fault && !vmf->cow_page) ? > + &xfs_dax_write_iomap_ops : > + &xfs_read_iomap_ops); > +} > +#endif Is there any reason this is in xfs_iomap.c and not xfs_file.c? Otherwise the patch looks good: Reviewed-by: Christoph Hellwig