From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D4BCC433EF for ; Mon, 9 May 2022 14:54:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B509B6B0072; Mon, 9 May 2022 10:54:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B006C6B0073; Mon, 9 May 2022 10:54:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C7876B0074; Mon, 9 May 2022 10:54:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8D51F6B0072 for ; Mon, 9 May 2022 10:54:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 678062F5F2 for ; Mon, 9 May 2022 14:54:04 +0000 (UTC) X-FDA: 79446499608.26.2D08339 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 026DB20090 for ; Mon, 9 May 2022 14:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mouIEtj76vKUUk31EBLG/iOWGo2/UyaQmgKTXKtrLoA=; b=Ar2deOFC+ZDQ8WgkdlKuls35H7 UwIY7pQVOfuQ16yaLcp8jVBq6Y5ukhGNGuYx6XQ09CKzF4jz+0FV13un2sSLrXznWoP/WSPf9OdJ4 XOSgVtdiU4I3x6aYy1BxRSMyLO3V7HZoaW7nJYn/fL+h0X0mTIauMd492RS8uPW6QzSY+u5FYAQhN xtWQaymXLdiqTzy+uIJ2XMY6DcDUY745xYZpInNcd7RMn9tNb41UF7Vxly1N8dbGzXsluAOejzQQ1 S+mHacRLTz1L1hOcYhfT1lLzbaarZ4wNbceavpIRNfAIOrvm7p5KsCHgkdfOchOj+7zO4LVKT93rV /OhIz5vQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1no4lo-003Xg5-LJ; Mon, 09 May 2022 14:53:56 +0000 Date: Mon, 9 May 2022 15:53:56 +0100 From: Matthew Wilcox To: Tom Rix Cc: hughd@google.com, akpm@linux-foundation.org, nathan@kernel.org, ndesaulniers@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] mm/shmem: initialize folio to NULL Message-ID: References: <20220509123116.3169267-1-trix@redhat.com> <0f066c75-121e-05f2-41ed-0d029bf70221@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f066c75-121e-05f2-41ed-0d029bf70221@redhat.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 026DB20090 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ar2deOFC; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: 3u53i75mjn7nh8iy13itg3gic85apukt X-HE-Tag: 1652108035-435074 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 09, 2022 at 07:51:25AM -0700, Tom Rix wrote: > > On 5/9/22 6:59 AM, Matthew Wilcox wrote: > > On Mon, May 09, 2022 at 08:31:16AM -0400, Tom Rix wrote: > > > The clang build fails with > > > mm/shmem.c:1704:7: error: variable 'folio' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] > > > if (!page) { > > > ^~~~~ > > > The error handler for !page jumps to an if-check for an unset folio. > > > So initialize folio to NULL. > > I appreciate you're trying to help, but the fourth report of a problem > > adds more noise than utility. > > > > https://lore.kernel.org/linux-mm/?q=shmem+folio > > > > shows emails about this from the cgelbot, Dan Carpenter, SeongJae Park, > > Colin King, Nathan Chancellor and Sebastian Siewior. So actually you > > were seventh, not fourth. > > From my point of view, the build has been broken for a week. Yeah, shit happens when you're trying to fix patches and attend a conference at the same time. > It would be good if this and the other folio issue was fixed in linux-next > soon. As you can see, I sent a replacement patch series on the 4th which fixes far more than the two problems you noticed. https://lore.kernel.org/linux-mm/20220504182857.4013401-1-willy@infradead.org/ I can do no more than this.