From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF42C433EF for ; Mon, 9 May 2022 13:59:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48ACB6B0072; Mon, 9 May 2022 09:59:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4399C6B0073; Mon, 9 May 2022 09:59:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 327F16B0074; Mon, 9 May 2022 09:59:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1F2EE6B0072 for ; Mon, 9 May 2022 09:59:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5AF43110B for ; Mon, 9 May 2022 13:59:54 +0000 (UTC) X-FDA: 79446363108.25.0339FF6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id A4CE9100092 for ; Mon, 9 May 2022 13:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BTWkAX27uDsyC4vbkOGDA43e2cUCH11HFcXPqJvTq38=; b=awER6OlTyq1mYQEExwvGUYw+4D lWQzXNQ+/jGS7ZpQrV6sXkNS6mi9eXaPYZLvAqQHZqOUj/1yub8lhIAxCrTDAGeUIgWmB8siFH/rx /pvAP14GNQiQPxPJY4XKvpqEDbKKEycfFFYOAQEcRDM42K/NKeBsJlXJeLHr6pP2jfzn27uubspLw bipjqgKe8Xo1L9fIJ/r4mpIxeJRRcQeaUlp9wUjsNdp44TuAuPY0nHgwYPrN0dHBEj0RRTBFI2AcW ZGYJohzAPUYd+xvr5xaYmkDRcSTNgY1n92uuEKZsdRaV7J4DX11Hj4CknTiU6VKTefvuI6w1Zy+0U UZmlp+MA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1no3vP-003VWx-9Y; Mon, 09 May 2022 13:59:47 +0000 Date: Mon, 9 May 2022 14:59:47 +0100 From: Matthew Wilcox To: Tom Rix Cc: hughd@google.com, akpm@linux-foundation.org, nathan@kernel.org, ndesaulniers@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] mm/shmem: initialize folio to NULL Message-ID: References: <20220509123116.3169267-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220509123116.3169267-1-trix@redhat.com> Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=awER6OlT; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A4CE9100092 X-Rspam-User: X-Stat-Signature: qnpwt1b6e1uaz9th15ghk9cx3x9mnqie X-HE-Tag: 1652104776-844816 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 09, 2022 at 08:31:16AM -0400, Tom Rix wrote: > The clang build fails with > mm/shmem.c:1704:7: error: variable 'folio' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] > if (!page) { > ^~~~~ > The error handler for !page jumps to an if-check for an unset folio. > So initialize folio to NULL. I appreciate you're trying to help, but the fourth report of a problem adds more noise than utility. https://lore.kernel.org/linux-mm/?q=shmem+folio shows emails about this from the cgelbot, Dan Carpenter, SeongJae Park, Colin King, Nathan Chancellor and Sebastian Siewior. So actually you were seventh, not fourth.