From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869B1C433F5 for ; Mon, 9 May 2022 13:22:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E67B6B0071; Mon, 9 May 2022 09:22:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 097E46B0073; Mon, 9 May 2022 09:22:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9F326B0074; Mon, 9 May 2022 09:22:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D90E66B0071 for ; Mon, 9 May 2022 09:22:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id A458860E45 for ; Mon, 9 May 2022 13:22:01 +0000 (UTC) X-FDA: 79446267642.18.E34E64C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 9D6BE400A9 for ; Mon, 9 May 2022 13:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JdggUdj6Cyy3bwI4A6a6CHtU1L9T2LeN0JfrMkS7X88=; b=OGd54kfOzMZGf7TJtvNXMhAtjf UjPVSXFqyFdCMYXg/C/rQjcYyMqLGOBYFnQO6phc6UMetLmgP17g2BX69Gueqvae3uDfoQU+KQErA VyxmD46+j3X9r+M0frtn07nO5Ixzz0akh0GX04/0k7ZPnuNVybVSoo55nFjgdcFtj1BDdbEtI19yr 8CbzmNlLvT8xRgzpWgZE1Ggg51rBMLdOO3mCkFbEiwNcsb7z/6fWDY0SpDmDe/vpdVSbTyu0NExyf tc2x67gNasvBr5ClgjoTU2k42s2Knv8CjP1UaovEgoWowJyBaFbO1ROCUqHxZTLFXVe7dwxiN0Uxu v0JnyYsg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1no3Ka-003Ta2-AV; Mon, 09 May 2022 13:21:44 +0000 Date: Mon, 9 May 2022 14:21:44 +0100 From: Matthew Wilcox To: Xiongwei Song , Zheng Liang , Phillip Lougher , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , Linus Torvalds Cc: Hsin-Yi Wang , "Song, Xiongwei" , "phillip@squashfs.org.uk" , "linux-mm@kvack.org" , "squashfs-devel@lists.sourceforge.net" Subject: Re: squashfs performance regression and readahea Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9D6BE400A9 X-Stat-Signature: am71gf7f7bpnzwfbnxbnqsha8hpob6a4 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OGd54kfO; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1652102511-213514 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 09, 2022 at 08:43:45PM +0800, Xiongwei Song wrote: > Hi Hsin-Yi and Matthew, > > With the patch from the attachment on linux 5.10, ran the command as I > mentioned earlier, > got the results below: > 1:40.65 (1m + 40.65s) > 1:10.12 > 1:11.10 > 1:11.47 > 1:11.59 > 1:11.94 > 1:11.86 > 1:12.04 > 1:12.21 > 1:12.06 > > The performance has improved obviously, but compared to linux 4.18, the > performance is not so good. > > Moreover, I wanted to test on linux 5.18. But I think I should revert > 9eec1d897139 ("squashfs: provide backing_dev_info in order to disable > read-ahead"), > right? Otherwise, the patch doesn't work? I've never seen patch 9eec1d897139 before. If you're going to point out bugs in my code, at least have the decency to cc me on it. It should never have gone in, and should be reverted so the problem can be fixed properly.