From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2932C433FE for ; Sun, 8 May 2022 20:37:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79A2D6B0071; Sun, 8 May 2022 16:37:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 749A96B0073; Sun, 8 May 2022 16:37:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6114A6B0074; Sun, 8 May 2022 16:37:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 51A356B0071 for ; Sun, 8 May 2022 16:37:30 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 1EE7460B8F for ; Sun, 8 May 2022 20:37:30 +0000 (UTC) X-FDA: 79443736260.08.FE78891 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id D945B14008F for ; Sun, 8 May 2022 20:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B4bamqMAO3dZ75ve9mJEU+0G2wDM1FM8qNboJ8U7p4w=; b=ZuSQINXidG6Y16ezDyl6FoU0C5 YDTSTgA/ApbR3DRXq9epJTZofYSVqyTw1kkAgTKRA5TkhYZAuDJgE20oN+0ENDRirDm4v56hli+6a AU0cTUzayoDWjZVvRvcjlPjzOzKpv5pDElHMLQZNvQYP9p/P/GZbUnv+DItfltBnhw+AMZy+Y9T9q 6Uj1WoZAkFXqTvikhQYy6WfvE+tsw62js9ps0GtAHMYxtkd76v0U6dWbStRifRxWCdREcyKqnKstG 3wQr4ALxxutm1WnuBpDuGhytLMFwBzXulkNDZ3KLnHAJSXKqTTK+ZGBFtZJ9NQH+HhPMAhNQLBT20 qyg/SOlw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnneY-002oI0-R0; Sun, 08 May 2022 20:37:18 +0000 Date: Sun, 8 May 2022 21:37:18 +0100 From: Matthew Wilcox To: Andrew Morton Cc: Vasily Averin , Steven Rostedt , Ingo Molnar , kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH mm] tracing: incorrect gfp_t conversion Message-ID: References: <331d88fe-f4f7-657c-02a2-d977f15fbff6@openvz.org> <20220507123728.f20d977eba9fbb66bddee722@linux-foundation.org> <8b1cfefa-da7d-3376-cf04-1ff77dab8170@openvz.org> <20220507154835.4d4d737d8eed579969f15938@linux-foundation.org> <20220507160010.aa2077e28c4710400e144bfb@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220507160010.aa2077e28c4710400e144bfb@linux-foundation.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D945B14008F Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZuSQINXi; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: xy5g48dssarmjqubxwhjwoak5to9aj8i X-HE-Tag: 1652042245-722042 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 07, 2022 at 04:00:10PM -0700, Andrew Morton wrote: > On Sat, 7 May 2022 15:48:35 -0700 Andrew Morton wrote: > > > I did the below. > > > > Silly me, doesn't work. > > > > > --- a/include/trace/events/mmflags.h~tracing-incorrect-gfp_t-conversion-fix > > +++ a/include/trace/events/mmflags.h > > @@ -13,53 +13,57 @@ > > * Thus most bits set go first. > > */ > > > > +#define FUL __force unsigned long > > + > > #define __def_gfpflag_names \ > > - {(__force unsigned long)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \ > > Can't expand FUL here within the macro definition. Can we do something even better? #define GFP_NAME(flag) { (__force unsigned long)flag, #flag }, ... with one or more layers of indirection to satisfy the arcane rules of C macros?