From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB78BC433EF for ; Fri, 6 May 2022 08:28:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F50B6B0071; Fri, 6 May 2022 04:28:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A54C6B0073; Fri, 6 May 2022 04:28:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06DDA6B0074; Fri, 6 May 2022 04:28:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EC3C76B0071 for ; Fri, 6 May 2022 04:28:55 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id C32F1120A60 for ; Fri, 6 May 2022 08:28:55 +0000 (UTC) X-FDA: 79434642630.21.5C242F0 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by imf16.hostedemail.com (Postfix) with ESMTP id 53431180026 for ; Fri, 6 May 2022 08:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651825734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z6z7gc/drMhEeRJp39wQIA1kBqGj2H/sPubOogLgDhI=; b=A67vUJX5fH8M7s3WoYJwV0JPKSDhKpWMeRITKwYBcr8twO00p9IjGHPfYNthtVoOi3kN2j LyKR1NUrqobFPkLf/jqo189xqZAPdadRzvffS/xLirRdBGSsA44p946gQDwfKTujHY7Z9x oscnTIm7CNZm674PXI6CYMsXOt1iUDE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-YPUZiyGDMOWmGfUE-_G9qw-1; Fri, 06 May 2022 04:28:53 -0400 X-MC-Unique: YPUZiyGDMOWmGfUE-_G9qw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8CEBB804199; Fri, 6 May 2022 08:28:52 +0000 (UTC) Received: from rh (vpn2-54-181.bne.redhat.com [10.64.54.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C9F62166B2D; Fri, 6 May 2022 08:28:52 +0000 (UTC) Received: from localhost ([::1] helo=rh) by rh with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nmtKT-005kR5-Fc; Fri, 06 May 2022 18:28:49 +1000 Date: Fri, 6 May 2022 18:28:47 +1000 From: Dave Chinner To: kernel test robot Cc: Chandan Babu R , "Darrick J. Wong" , LKML , Linux Memory Management List , lkp@lists.01.org, lkp@intel.com Subject: Re: [xfs] 83a21c1844: xfstests.xfs.533.fail Message-ID: References: <20220506080341.GF23061@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220506080341.GF23061@xsang-OptiPlex-9020> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A67vUJX5; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of dchinner@redhat.com has no SPF policy when checking 170.10.133.74) smtp.mailfrom=dchinner@redhat.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 53431180026 X-Rspam-User: X-Stat-Signature: ebkja6rjg9nceqmwtyn8n1pan16kajoc X-HE-Tag: 1651825728-232479 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 06, 2022 at 04:03:41PM +0800, kernel test robot wrote: > > > Greeting, > > FYI, we noticed the following commit (built with gcc-11): > > commit: 83a21c18441f75aec64548692b52d34582b98a6a ("xfs: Directory's data fork extent counter can never overflow") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > in testcase: xfstests > version: xfstests-x86_64-46e1b83-1_20220414 > with following parameters: > > disk: 4HDD > fs: xfs > test: xfs-group-53 > ucode: 0x21 > > test-description: xfstests is a regression test suite for xfs and other files ystems. > test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git > > > on test machine: 4 threads 1 sockets Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz with 8G memory > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > > If you fix the issue, kindly add following tag > Reported-by: kernel test robot > > > xfs/533 [failed, exit status 1]- output mismatch (see /lkp/benchmarks/xfstests/results//xfs/533.out.bad) > --- tests/xfs/533.out 2022-04-14 12:51:49.000000000 +0000 > +++ /lkp/benchmarks/xfstests/results//xfs/533.out.bad 2022-05-03 06:24:37.310381846 +0000 > @@ -6,12 +6,4 @@ > Inject bmap_alloc_minlen_extent error tag > * Create directory entries > Verify directory's extent count > -* Rename: Populate destination directory > -Populate $dstdir by moving new directory entries > -Verify $dstdir's extent count > -* Create multiple hard links to a single file > ... > (Run 'diff -u /lkp/benchmarks/xfstests/tests/xfs/533.out /lkp/benchmarks/xfstests/results//xfs/533.out.bad' to see the entire diff) Not a regression. This is testing directory data fork extent count overflow using error injection, but you might notice that the title of the commit is "Directory's data fork extent counter can never overflow". IOWs, we changed fine grained directory extent count overflow from a runtime check (on every dir op) to an inode verifier check that is only run when the directory inode is read from or written to disk. The test probably should be removed. Chandan? Cheers, Dave. -- Dave Chinner dchinner@redhat.com