From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1E2C43217 for ; Fri, 6 May 2022 07:32:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 323006B0071; Fri, 6 May 2022 03:32:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D2BB6B0073; Fri, 6 May 2022 03:32:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 199266B0074; Fri, 6 May 2022 03:32:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 0A64D6B0071 for ; Fri, 6 May 2022 03:32:05 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B6D5F18590804 for ; Fri, 6 May 2022 07:32:04 +0000 (UTC) X-FDA: 79434499368.29.6B6C7B5 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf16.hostedemail.com (Postfix) with ESMTP id B1621180039 for ; Fri, 6 May 2022 07:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651822323; x=1683358323; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SkwnacsNYIuKuqUXcnje2/FShCNjGYncVyvTKO9Qoz4=; b=SqXZHP6nKr9UiSXBzXiUXmyQcB3+nUGXNq3DCfuQLITLSHXZFTboNGeG k2+klmcAcedlMjZUWXewtYg74vaQdFGfbzKsgGTHXtBCvWj7QnRHd0z2f iqxbpkDatnkduzDtiUe7W3d4xcx5zjZCQsZlrrF8lfaaT1uoTq7Vt8jpf C7vaGYPYO+aE8ZPvzo3IEcZAtldYkyLogv00OXgxLUDU6f5vYFfLXHj2U tIi2eE7zJTSTuolJyo2HX4G9MOWu93YwXXZR25xhU/XXRSZysmyzJhP7g Tv/SwXu/Ur2tG749dAWWq/L98klE0uBjm650sEOzlIYhsNqKxHCdy/HYy A==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="267221056" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="267221056" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 00:31:57 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="563686566" Received: from rli9-dbox.sh.intel.com (HELO rli9-dbox) ([10.239.159.142]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 00:31:54 -0700 Date: Fri, 6 May 2022 15:30:05 +0800 From: Philip Li To: Ard Biesheuvel Cc: Dave Hansen , Arnd Bergmann , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Message-ID: References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B1621180039 X-Stat-Signature: xm48rk8pfrudmerfjupbiy63ii1s4bwi Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SqXZHP6n; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf16.hostedemail.com: domain of philip.li@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=philip.li@intel.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1651822315-191195 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 06, 2022 at 09:24:26AM +0200, Ard Biesheuvel wrote: > On Fri, 6 May 2022 at 03:12, Philip Li wrote: > > > > On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > > > On 5/3/22 00:21, Arnd Bergmann wrote: > > > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > > >> From: kernel test robot > > > >> > > > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > > >> > > > >> Remove unneeded variable used to store return value. > > > >> > > > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > > > >> > > > >> Reported-by: kernel test robot > > > >> Signed-off-by: kernel test robot > > > > I checked the patch, and unfortunately it is wrong, the current code > > > > needs to stay. > > > > The problem is the SET_DMA_ERRATA() macro that accesses the > > > > local 'errata' variable. > > > > > > 0day folks, do we have humans looking over these before they're going > > > out to the list? If not, can we add some? If so, can the humans get a > > > little more discerning? ;) > > > > Sorry all for the bad patch. So far, we pick up several cocci warnings that > > we have confidence based on early result analysis and feedback, for these > > warnings, 0day sends out patch automatically. > > > > Could you please add a special header or something to such emails so I > can filter them out? I am strongly opposed to such automatic spambot > patch generation, as it wastes valuable reviewer bandwidth to save the > bot operator some time, but it think it should be the other way > around. Sorry for the trouble, we will stop sending the patch automatically and only send out patch after human confirmed/reviewed. > > We expect contributors to carefully prepare their patch submissions > before sending them to the list, and automatically generated patches > simply don't mesh with that. The fact that you use a bot does not mean > you can ignore these rules. Got it, we will improve this to follow the right way to send out patches. Thanks