From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D53C433FE for ; Fri, 6 May 2022 01:11:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A93D06B0071; Thu, 5 May 2022 21:11:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A411B6B0073; Thu, 5 May 2022 21:11:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 894696B0074; Thu, 5 May 2022 21:11:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 74CEE6B0071 for ; Thu, 5 May 2022 21:11:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2D4502D85D for ; Fri, 6 May 2022 01:11:09 +0000 (UTC) X-FDA: 79433539458.28.2594B86 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf28.hostedemail.com (Postfix) with ESMTP id 070CFC008B for ; Fri, 6 May 2022 01:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651799468; x=1683335468; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=r/8ZoH7x8kextBDC9EcGTqQBcpjNzluLvqs0Fv7Xd98=; b=fv35loPwKp/J40AwrhXugsvdPvoLOpizdCll35agj0Pkb9Lf4dAelQki xt1YidfVDT7cLgM/RJ1EBeZ0cIJICoILZoyCzRjCf0KFj48F0iJ8l0tmK vhWzC4reI8SX+ox4m82em7HH1isTVEczEoMO2fXq9pHtPEqGQVv6j6SDe OfnpacFKSavt0Z6T6h1qbWx3pvlSzL/msqJaXr55hNwkAxHdhQNY05CX3 KUkY4iMzrC0TQXV5oK7Pa8LkwZo+e0jwC+kge44I3dMC4iZTHYtrTMs3N hKUq/yubsAmn/OHdZEGxfjkSThdcwznphSRW5Q70OkU7pVOyA98CkgS2E A==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="250301061" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="250301061" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:11:05 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="537630977" Received: from rli9-dbox.sh.intel.com (HELO rli9-dbox) ([10.239.159.142]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:11:02 -0700 Date: Fri, 6 May 2022 09:09:13 +0800 From: Philip Li To: Dave Hansen Cc: Arnd Bergmann , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Message-ID: References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fv35loPw; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of philip.li@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=philip.li@intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 070CFC008B X-Rspam-User: X-Stat-Signature: 4sbiwitzwct6xkces48i4d4jgm6c815r X-HE-Tag: 1651799452-477235 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > On 5/3/22 00:21, Arnd Bergmann wrote: > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > >> From: kernel test robot > >> > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > >> > >> Remove unneeded variable used to store return value. > >> > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > >> > >> Reported-by: kernel test robot > >> Signed-off-by: kernel test robot > > I checked the patch, and unfortunately it is wrong, the current code > > needs to stay. > > The problem is the SET_DMA_ERRATA() macro that accesses the > > local 'errata' variable. > > 0day folks, do we have humans looking over these before they're going > out to the list? If not, can we add some? If so, can the humans get a > little more discerning? ;) Sorry all for the bad patch. So far, we pick up several cocci warnings that we have confidence based on early result analysis and feedback, for these warnings, 0day sends out patch automatically. Thanks for the suggestion Dave, We will change current process to be more conservative and to avoid false patch by adding human analysis. Thanks