linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/shmem: Fix uninitialized variable bug
@ 2022-05-05 10:29 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-05-05 10:29 UTC (permalink / raw)
  To: Hugh Dickins, Matthew Wilcox (Oracle)
  Cc: Andrew Morton, linux-mm, kernel-janitors

The "folio" pointer is not initialized on some of the early error
paths.

Fixes: 2b58b3f33ba2 ("mm/shmem: convert shmem_swapin_page() to shmem_swapin_folio()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This goes through Andrew's tree and will presumably be folded in with
the original patch.

 mm/shmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 107f1e4dd0aa..97f9ea59a7d1 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1681,8 +1681,8 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index,
 	struct address_space *mapping = inode->i_mapping;
 	struct shmem_inode_info *info = SHMEM_I(inode);
 	struct mm_struct *charge_mm = vma ? vma->vm_mm : NULL;
+	struct folio *folio = NULL;
 	struct page *page;
-	struct folio *folio;
 	swp_entry_t swap;
 	int error;
 
-- 
2.35.1



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-05 10:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 10:29 [PATCH] mm/shmem: Fix uninitialized variable bug Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox