From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A908FC433F5 for ; Wed, 4 May 2022 06:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95BC86B0071; Wed, 4 May 2022 02:28:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90AFC6B0073; Wed, 4 May 2022 02:28:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F9B36B0074; Wed, 4 May 2022 02:28:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 72AB16B0071 for ; Wed, 4 May 2022 02:28:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 48053608AA for ; Wed, 4 May 2022 06:28:05 +0000 (UTC) X-FDA: 79427080530.22.07686B4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 17886140080 for ; Wed, 4 May 2022 06:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mLg1H11s7vwLj6tClFSIgTh3DOgfbrxxwGziAtkuLp4=; b=eV214LHb/UZi0ZSrWlQMcNMG5g DpH8mozghTyqroVmN4m8MymM9ejFV7R7x1XGd2y2XZJo3SfvtSUk3uEK6blqWeZru7CfRlYp0ez60 yzagl3xaydH9tu6MXX5z3UgbRnoh+xQSHer9aTuu3hlAslwES1f17TClD9b91jMbZeIA0XqhByXEb 6nMQ9lqfQj4d85bDzJGPWQzhOH3mldD8Z91WJoSOyRDZ9QP8SVeSkSyRc8qCk3WlX19Zu5vfuedcL dZqvWdZzZa91CLaP5gE2DAPaKVWXCh0qta43j9P6e8qu5i0isgyKXisYBB1CndthS8VV7RRLlGcBI MJcnUMTQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nm8Cf-00GHkz-9X; Wed, 04 May 2022 06:09:37 +0000 Date: Wed, 4 May 2022 07:09:37 +0100 From: Matthew Wilcox To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , Suren Baghdasaryan , Michal Hocko , John Dias , Tim Murray Subject: Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path Message-ID: References: <20220503170341.1413961-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 17886140080 X-Stat-Signature: fen9a6rceettstjgmcdp8jxs48izet4b Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eV214LHb; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1651645674-286576 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 03, 2022 at 09:30:38PM -0700, Minchan Kim wrote: > On Wed, May 04, 2022 at 04:32:13AM +0100, Matthew Wilcox wrote: > > On Tue, May 03, 2022 at 10:03:41AM -0700, Minchan Kim wrote: > > > -void rmap_walk(struct folio *folio, const struct rmap_walk_control *rwc); > > > -void rmap_walk_locked(struct folio *folio, const struct rmap_walk_control *rwc); > > > +void rmap_walk(struct folio *folio, struct rmap_walk_control *rwc); > > > +void rmap_walk_locked(struct folio *folio, struct rmap_walk_control *rwc); > > > > I see the build bot already beat me to pointing out why this is wrong, > > but do you not look at git log to figure out why code was changed to be > > the way it is now, before you change it back? > > This patch added a new field as out param like compact_control so > the rmap_walk_control is not immutable. ... but we have a user which treats it as if it is.