From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D61EC433F5 for ; Wed, 4 May 2022 04:30:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C00056B0071; Wed, 4 May 2022 00:30:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAFC16B0073; Wed, 4 May 2022 00:30:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A77B26B0074; Wed, 4 May 2022 00:30:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 93FA06B0071 for ; Wed, 4 May 2022 00:30:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6016D209B2 for ; Wed, 4 May 2022 04:30:42 +0000 (UTC) X-FDA: 79426784724.11.BFA6AE4 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf10.hostedemail.com (Postfix) with ESMTP id 71CEBC007F for ; Wed, 4 May 2022 04:30:26 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id w5-20020a17090aaf8500b001d74c754128so4205615pjq.0 for ; Tue, 03 May 2022 21:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ss87FSqUni7rDXSoxiu7XmQ/S9n/UK2R/Ew6b8zs5Do=; b=YyZvqaN8apSl08J8dH8FGbeUv8c4HJ/nHqUrqhpiuVq5HEEeW8jpk5PgiodHWz5sSu BjCUdhXJhsgk9WpSJBE6W3Rh5ls7C7zkKCJkrUpBtJvipm0D3pZo2XHY0C3Foa0aVnN5 ExH2IgR6gIiHgEruLe4RLzYalm9hE3xbsGe/jFxy+KQaX4xE5+foGVK460WGikbYa6Cq 2+wqYq8EChJlZMgC+nGcp1Y8As8trJTcsv1bTh2i5RBYXIcBUnqTdhEhQVZqPxM8dASr oBAD6HGp3PW9Cpbo6seeOXqtst70QXBizSICfi71ZZ3f0zQmjQKkLRl5oJcNZe4lWNvK agWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=ss87FSqUni7rDXSoxiu7XmQ/S9n/UK2R/Ew6b8zs5Do=; b=AFYkGWvwcf0+zyoiC562qzSJCOCJ7BimoupnQfCl6uPnOmAYp+vnQN1x/nnORe8xtY 80pROEHDgvDGi05+huZdTrclEzOoD410TXtGzRGVZSSrRkdljY182Qw0beNFPPRCl8vC zczNVerqN/X494/vuuStY1amd/phhdx+mxMI7hgHie5XbUwB25x5FAQejxMtMrwd+Pcz lg8K04+5dePzQB7d+OOsFyCWx4McJZqkrCZd1oYFiqcP5pXHwhbrti4pU3wdBzFsBtO2 q/Y182X/kQIKuAT5jJjREq9V3JdcEgxmFVrnPDAfEG5SGa9gO2SZfKKGmv/nVEczKh/N Jkqw== X-Gm-Message-State: AOAM531ZuQUgp+AnKa+o3Mqe9RzNweAVLW3Uxnm9UNkMdwLAc8/d5dUu cxaxI5JZfLc5OsqxaEBX1LU= X-Google-Smtp-Source: ABdhPJy2Y5/8OtXOPu/c1PKe4tkQfKkiCMcKdk/4GYE24NkhI+XeVbHPONv8WcaSkpFIqymsNUncQg== X-Received: by 2002:a17:902:c78b:b0:15c:e5dc:4f63 with SMTP id w11-20020a170902c78b00b0015ce5dc4f63mr20013137pla.90.1651638641034; Tue, 03 May 2022 21:30:41 -0700 (PDT) Received: from google.com ([2620:15c:211:201:8998:54e:9def:1e7c]) by smtp.gmail.com with ESMTPSA id w10-20020a170902d3ca00b0015e8d4eb298sm7153537plb.226.2022.05.03.21.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 21:30:40 -0700 (PDT) Date: Tue, 3 May 2022 21:30:38 -0700 From: Minchan Kim To: Matthew Wilcox Cc: Andrew Morton , LKML , linux-mm , Suren Baghdasaryan , Michal Hocko , John Dias , Tim Murray Subject: Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path Message-ID: References: <20220503170341.1413961-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 71CEBC007F X-Stat-Signature: 57gp8wbrd91itps9o4m448s1amko649s X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YyZvqaN8; spf=pass (imf10.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-HE-Tag: 1651638626-836872 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000610, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 04, 2022 at 04:32:13AM +0100, Matthew Wilcox wrote: > On Tue, May 03, 2022 at 10:03:41AM -0700, Minchan Kim wrote: > > -void rmap_walk(struct folio *folio, const struct rmap_walk_control *rwc); > > -void rmap_walk_locked(struct folio *folio, const struct rmap_walk_control *rwc); > > +void rmap_walk(struct folio *folio, struct rmap_walk_control *rwc); > > +void rmap_walk_locked(struct folio *folio, struct rmap_walk_control *rwc); > > I see the build bot already beat me to pointing out why this is wrong, > but do you not look at git log to figure out why code was changed to be > the way it is now, before you change it back? This patch added a new field as out param like compact_control so the rmap_walk_control is not immutable.