From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1CFC433EF for ; Wed, 4 May 2022 03:32:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE11F6B0071; Tue, 3 May 2022 23:32:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6AD96B0073; Tue, 3 May 2022 23:32:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90B446B0074; Tue, 3 May 2022 23:32:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 778426B0071 for ; Tue, 3 May 2022 23:32:23 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 45C04299E9 for ; Wed, 4 May 2022 03:32:23 +0000 (UTC) X-FDA: 79426637766.06.CBBD643 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 4450714006E for ; Wed, 4 May 2022 03:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=x56R5P5Ovst1E8E/m3Q42KgG3BOgifNTi5pj7aSPnuQ=; b=OC5188RCeNmzIV/clsEa71+0AM 8kZE/w3O1HprWmJBAKnItAlcllSYAUUyyUTK9J+oYNHpXst53X8tsrtpbbDQjkWuNBMGGx63gAkV0 +bof377JuUv9evhToXmbfYVYyOicOPYAa3vxUIldkdfT6+n9Sm5zc87sH3Z3mC0VDMkqdD6q19/Lu AlH6nGuFL+Dj6vv/XzsWX2kF3DICyR0RNzkV/EFMIfqzRInT1UfglZbx0+Dt94FNfUUlptScc6rdi p4I1tgoEh1RhQfCXojJGZLcMM9JPj453nPBKNtFpZc1PpJWoE9jVJDq9yXv/vyamGag0lvqVIC5+M Q4/FXLUg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nm5kL-00GCYk-Id; Wed, 04 May 2022 03:32:13 +0000 Date: Wed, 4 May 2022 04:32:13 +0100 From: Matthew Wilcox To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , Suren Baghdasaryan , Michal Hocko , John Dias , Tim Murray Subject: Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path Message-ID: References: <20220503170341.1413961-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503170341.1413961-1-minchan@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 4450714006E X-Stat-Signature: wisk13zaf8hyte1y5yw951tixnyg8f5d Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OC5188RC; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1651635136-215475 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 03, 2022 at 10:03:41AM -0700, Minchan Kim wrote: > -void rmap_walk(struct folio *folio, const struct rmap_walk_control *rwc); > -void rmap_walk_locked(struct folio *folio, const struct rmap_walk_control *rwc); > +void rmap_walk(struct folio *folio, struct rmap_walk_control *rwc); > +void rmap_walk_locked(struct folio *folio, struct rmap_walk_control *rwc); I see the build bot already beat me to pointing out why this is wrong, but do you not look at git log to figure out why code was changed to be the way it is now, before you change it back?