From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90852C433F5 for ; Tue, 3 May 2022 11:10:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4D256B0071; Tue, 3 May 2022 07:10:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD4536B0073; Tue, 3 May 2022 07:10:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75936B0074; Tue, 3 May 2022 07:10:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 9238C6B0071 for ; Tue, 3 May 2022 07:10:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5DCF02259A for ; Tue, 3 May 2022 11:10:14 +0000 (UTC) X-FDA: 79424162748.22.B1883F5 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf03.hostedemail.com (Postfix) with ESMTP id D903420072 for ; Tue, 3 May 2022 11:10:07 +0000 (UTC) Date: Tue, 3 May 2022 13:10:09 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1651576210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U1Ni9a4Wk4nc8XJmvT4mu+d2QkEGhovLKmgMcM1Wwco=; b=27cCOZAyD60V5Y0F5ZvNS/Noj022agaiXhwLXcGi99Su0xppqVoZp1uvBxzW8FCVFI47JJ c0y5Bvu1hrV5q1oYVapCHyLVxdRfJLo8ICcNZdPbPxfCwyZrJ4S4f22nxwEzBoBEX5Wz26 5YlT03qHExmWOIezy+54fb23DorQk2dkzoxrQlBHnMh5JHsSRKoHOJ9rT1bf4nB2NiPJ9w 5DK4oWICH5qWlbhj8DPsCFi0wkTBDATzCgmZnBkp3YCXM7BKtJogokl+NRlOQRonelTeS0 A/Tc5q5/USgmVDTfHN7cSccRwT0vSdjHi/5XpG7QSn0sq1BmmXh2kRVtVpfv6Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1651576210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U1Ni9a4Wk4nc8XJmvT4mu+d2QkEGhovLKmgMcM1Wwco=; b=Nhjb/AywFRo9DD1dc3fwYMKA144xuvEyugoQU+qgkFIcS0s8xMxvdIdSQji7An9Of/XXsi yRPQKY+7UECu5dBA== From: Sebastian Andrzej Siewior To: "Matthew Wilcox (Oracle)" Cc: akpm@linuxfoundation.org, linux-mm@kvack.org, tglx@linutronix.de Subject: Re: [PATCH 16/21] mm/shmem: Convert shmem_add_to_page_cache to take a folio Message-ID: References: <20220429192329.3034378-1-willy@infradead.org> <20220429192329.3034378-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220429192329.3034378-17-willy@infradead.org> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D903420072 X-Stat-Signature: z566rtt1e6jz6xceahwd46nyjiwxmg8i X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=27cCOZAy; dkim=pass header.d=linutronix.de header.s=2020e header.b="Nhjb/Ayw"; spf=pass (imf03.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-HE-Tag: 1651576207-135812 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-04-29 20:23:24 [+0100], Matthew Wilcox (Oracle) wrote: > diff --git a/mm/shmem.c b/mm/shmem.c > index 3461bdec6b38..4331a4daac01 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -736,16 +735,16 @@ static int shmem_add_to_page_cache(struct page *pag= e, > xas_set_err(&xas, -EEXIST); > goto unlock; > } > - xas_store(&xas, page); > + xas_store(&xas, folio); > if (xas_error(&xas)) > goto unlock; > - if (PageTransHuge(page)) { > + if (folio_test_large(folio)) { > count_vm_event(THP_FILE_ALLOC); > - __mod_lruvec_page_state(page, NR_SHMEM_THPS, nr); > + __lruvec_stat_mod_folio(folio, NR_SHMEM_THPS, nr); > } | CC mm/shmem.o |In file included from : |mm/shmem.c: In function =E2=80=98shmem_add_to_page_cache=E2=80=99: |include/linux/compiler_types.h:352:45: error: call to =E2=80=98__compileti= me_assert_262=E2=80=99 declared with attribute error: BUILD_BUG failed | 352 | _compiletime_assert(condition, msg, __compiletime_assert_,= __COUNTER__) | | ^ =E2=80=A6 |mm/shmem.c:743:40: note: in expansion of macro =E2=80=98THP_FILE_ALLOC=E2= =80=99 | 743 | count_vm_event(THP_FILE_ALLOC); | | ^~~~~~~~~~~~~~ | and=20 | $ git grep THP_FILE_ALLOC | include/linux/vm_event_item.h: THP_FILE_ALLOC, | include/linux/vm_event_item.h:#define THP_FILE_ALLOC ({ BUILD_BUG(); 0; }) | mm/shmem.c: count_vm_event(THP_FILE_ALLOC); | $ grep CONFIG_TRANSPARENT_HUGEPAGE .config | # CONFIG_TRANSPARENT_HUGEPAGE is not set Sebastian