linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ARM: dove: fix returnvar.cocci warnings
Date: Tue, 3 May 2022 10:45:32 +0800	[thread overview]
Message-ID: <YnCXTPrbLhvfRVDm@e3a974050dc4> (raw)
In-Reply-To: <202205031017.4TwMan3l-lkp@intel.com>

From: kernel test robot <lkp@intel.com>

arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9f9b9a2972eb8dcaad09d826c5c6d7488eaca3e6
commit: 09f6b27d5ddd9ad0ec096d1b0f8decdacc70f0f8 [1066/8035] ARM: dove: multiplatform support
:::::: branch date: 15 hours ago
:::::: commit date: 4 weeks ago

 arch/arm/mach-omap2/dma.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/arch/arm/mach-omap2/dma.c
+++ b/arch/arm/mach-omap2/dma.c
@@ -79,8 +79,6 @@ static const struct omap_dma_reg reg_map
 
 static unsigned configure_dma_errata(void)
 {
-	unsigned errata = 0;
-
 	/*
 	 * Errata applicable for OMAP2430ES1.0 and all omap2420
 	 *
@@ -158,7 +156,7 @@ static unsigned configure_dma_errata(voi
 	if (cpu_is_omap34xx() && (omap_type() != OMAP2_DEVICE_TYPE_GP))
 		SET_DMA_ERRATA(DMA_ROMCODE_BUG);
 
-	return errata;
+	return 0;
 }
 
 static const struct dma_slave_map omap24xx_sdma_dt_map[] = {


  reply	other threads:[~2022-05-03  2:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03  2:47 [linux-next:master 1066/8035] arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 kernel test robot
2022-05-03  2:45 ` kernel test robot [this message]
2022-05-03  7:21   ` [PATCH] ARM: dove: fix returnvar.cocci warnings Arnd Bergmann
2022-05-03  7:30     ` Tony Lindgren
2022-05-03  7:53       ` Arnd Bergmann
2022-05-03  8:23         ` Tony Lindgren
2022-05-05 16:31     ` Dave Hansen
2022-05-06  1:09       ` Philip Li
2022-05-06  7:17         ` Arnd Bergmann
2022-05-06  7:32           ` Philip Li
2022-05-06  7:24         ` Ard Biesheuvel
2022-05-06  7:30           ` Philip Li
2022-05-05 14:08   ` Russell King (Oracle)
2022-05-06  1:09     ` [kbuild-all] " Philip Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnCXTPrbLhvfRVDm@e3a974050dc4 \
    --to=lkp@intel.com \
    --cc=arnd@arndb.de \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox