From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B3ECC433F5 for ; Fri, 13 May 2022 23:54:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 688866B0073; Fri, 13 May 2022 19:54:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 636636B0075; Fri, 13 May 2022 19:54:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FF666B0078; Fri, 13 May 2022 19:54:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3E5956B0073 for ; Fri, 13 May 2022 19:54:12 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0BB88A6F for ; Fri, 13 May 2022 23:54:12 +0000 (UTC) X-FDA: 79462375944.22.5D4D37D Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf29.hostedemail.com (Postfix) with ESMTP id B62751200CC for ; Fri, 13 May 2022 23:54:03 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id w17-20020a17090a529100b001db302efed6so9122419pjh.4 for ; Fri, 13 May 2022 16:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YqXCGyPsp5ArB5dqL4pL5ev2vTjEI3622aS8uMXTUU8=; b=DwM4B8SfDuhyFXUnZbAL/ZY/DcRWWDHSvQn+FjKOPeOJaj4vRugCoD4Q6EyH8ejoNp c5GkcuheJ6uVTHxI1r/k46H944JxYU2cO8FvvYHaov0k/7zKxkRLm2uii1ka82lbkE8y kkXQkFIqfcn7EHZE9r+UQEnd7O8o/kzC45WvCZlcvIZwJlt2aFz0IOCOkx/EStnddHfo YbwZRpt1F/PeXQg5dgEPIDUOlrpBwRxdVdVZ9YtmBNphMaKKFfk/yqyGyQCTBbmZ69gL awkai/OcYtvaBdC4OJtVvUdk/yevN6l6nrdMuf+6SZD+pFqf3pm9Fq6lnjFqIUKmiTlx L6KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=YqXCGyPsp5ArB5dqL4pL5ev2vTjEI3622aS8uMXTUU8=; b=3RYzb+50lq4C8nn695h/99toAnpzMQ2/dNn2Mp/FeF0VvmtCK9eu9HEZuoypf6pSCd vMOPnwapEpi6EJ1dg22On2i5ilFGuh/gcIKRcaOGeZ+TavypVblZEYN6wQXlcWUv79P3 7idVqca0bMjN2zXtIt9xnr/5O/usv1dB1YklOpy2dXJjYWCtL0HxXwzw4mmWfyigZtBG c1PSpQHVxqUcBLMJWexFn5Yr0tz2qb5X68skjbxePlr7ZRUIky4/rPJsRoTvFk0Osqme 6ur51l4WjSs/+1KSBcQB5I17QeWKthwRoiWMPoWSad6gzQZaB14dvGxv+bKoXsi70MWY RTvw== X-Gm-Message-State: AOAM530dx00FocYmfFLow4ugupE4S62+FtgU8b5Pz37dmcROWLW1Q9sR FDdafvBAmBuDLwuAfURD+Dg= X-Google-Smtp-Source: ABdhPJz+2AgJW+UNcOEnQyMmoDiDLnajAAFPWMpiflOrjAp91f9dxcR/08AkhNhPCCw2na7Tk8dLFQ== X-Received: by 2002:a17:903:246:b0:153:87f0:a93e with SMTP id j6-20020a170903024600b0015387f0a93emr7165067plh.171.1652486048731; Fri, 13 May 2022 16:54:08 -0700 (PDT) Received: from google.com ([2620:15c:211:201:1969:9b8a:5056:897b]) by smtp.gmail.com with ESMTPSA id z25-20020a62d119000000b0050dc762816fsm2326286pfg.73.2022.05.13.16.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 16:54:08 -0700 (PDT) Date: Fri, 13 May 2022 16:54:06 -0700 From: Minchan Kim To: Andrew Morton Cc: Mike Kravetz , syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, nathan@kernel.org, ndesaulniers@google.com, syzkaller-bugs@googlegroups.com, trix@redhat.com, Matthew Wilcox , Stephen Rothwell , John Hubbard , David Hildenbrand Subject: Re: [syzbot] WARNING in follow_hugetlb_page Message-ID: References: <000000000000ef451a05dee0f2b1@google.com> <00000000000077377c05dee75f63@google.com> <20220513102617.c464c4f566052838e911a3ec@linux-foundation.org> <75f09063-d184-7d44-17a1-ed04be5eb953@oracle.com> <20220513161910.d1b73583cdb2e33562aa86e5@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220513161910.d1b73583cdb2e33562aa86e5@linux-foundation.org> X-Rspamd-Queue-Id: B62751200CC X-Stat-Signature: 7onaquf4k5gipcdm53k5wya6e1erwa4a X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DwM4B8Sf; spf=pass (imf29.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam09 X-HE-Tag: 1652486043-877236 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 13, 2022 at 04:19:10PM -0700, Andrew Morton wrote: > On Fri, 13 May 2022 15:48:15 -0700 Mike Kravetz wrote: > > > On 5/13/22 11:09, Mike Kravetz wrote: > > > On 5/13/22 10:26, Andrew Morton wrote: > > >> On Fri, 13 May 2022 09:43:24 -0700 syzbot wrote: > > >> > > >>> syzbot has found a reproducer for the following issue on: > > >> > > >> Thanks. > > >> > > >>> HEAD commit: 1e1b28b936ae Add linux-next specific files for 20220513 > > >>> git tree: linux-next > > >>> console+strace: https://syzkaller.appspot.com/x/log.txt?x=174ae715f00000 > > >>> kernel config: https://syzkaller.appspot.com/x/.config?x=e4eb3c0c4b289571 > > >>> dashboard link: https://syzkaller.appspot.com/bug?extid=acf65ca584991f3cc447 > > >>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > >>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11531766f00000 > > >>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16ce5a9ef00000 > > >>> > > >>> IMPORTANT: if you fix the issue, please add the following tag to the commit: > > >>> Reported-by: syzbot+acf65ca584991f3cc447@syzkaller.appspotmail.com > > >>> > > >>> ------------[ cut here ]------------ > > >>> WARNING: CPU: 1 PID: 3611 at mm/hugetlb.c:6250 follow_hugetlb_page+0x1326/0x1c80 mm/hugetlb.c:6250 > > >> > > >> The try_grab_folio() added by 822951d84684d ("mm/hugetlb: Use > > >> try_grab_folio() instead of try_grab_compound_head()"). That commit > > >> has been there over a month so I guess it's something else. Does > > >> someone have the time to bisect? > > > > > > I can recreate in my 'easy to debug' environment, so I can bisect in > > > parallel with other things I need to do today. > > > > > > > I isolated this to Minchan Kim's "mm: fix is_pinnable_page against on cma > > page". Yes, the fat finger fix is in next-20220513. > > > > I don't have time to analyze right now, but can confirm that in the > > reproducer is_pinnable_page is returning false after this change when it > > previously returned true. > > OK, thanks, I dropped mm-fix-is_pinnable_page-against-on-cma-page.patch Seems like bug of the patch v5 due to change of this if (mt & (MIGRATE_CMA | MIGRATE_ISOLATE)) The migration type is not bit type so it shold be if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE) Ccing just in case if I miss other thing for HugeTLB