From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C4BC433F5 for ; Fri, 13 May 2022 18:28:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2BCB6B0073; Fri, 13 May 2022 14:28:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8CB16B0075; Fri, 13 May 2022 14:28:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9078A6B0078; Fri, 13 May 2022 14:28:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7E3106B0073 for ; Fri, 13 May 2022 14:28:29 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4CB9D2FBFC for ; Fri, 13 May 2022 18:28:29 +0000 (UTC) X-FDA: 79461555138.13.A525825 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf31.hostedemail.com (Postfix) with ESMTP id B23D5200AF for ; Fri, 13 May 2022 18:28:04 +0000 (UTC) Received: by mail-ed1-f49.google.com with SMTP id be20so10857594edb.12 for ; Fri, 13 May 2022 11:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4iZmYfwWJ4woLfygxHtDQ1H4+/ycf7nk+QQuS21hmvo=; b=Ju/51i1Gn+EvxVCj5va4zj4cWTnpJ8rAwoJJG8oDH+ZKss/MR6QSw6s+r/OXa7ndDK lFTYy5r5MH7C+sND13Em2HCxaotw4gxZqjcNjXyblohb4GwJvfZDjsEDa6mI/v1+e6Yd 9hOgacoj6IBZRRDS8wFTgjb14txd29YEcS+KQ9AqQEoo/+lF2zotBTqOhLgkad8WE6nr WE15AIouxL0xXmLcPUfK8a8k3SbQjJ1GRj3PXybtkvr83E5TmeVhrx9VT1NUKl82j4Wz OSYd7bWwgUCYw8QEsW8vtecZZTqzdRQZsweWwU2jr8HV5M/+64wbwJkuw0eUu3cTQV5E fldA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4iZmYfwWJ4woLfygxHtDQ1H4+/ycf7nk+QQuS21hmvo=; b=2ZD6mdkeGCkgZZ+p0qZx+aAZQ/k0NrFIWcKk0fZy6OvSehVkd9sNGdvFR0tx8g68aK lSXNGDU//Qh87JMc7YhO5bEgDAkNOfWAtiXEFJF8SwSumLqXkvQXbiZtcgkNxGyEmBhc vQdyb/mCZAv/OGE6vK5ksOtrsuABvo386bZaGj0Di8NcENcOtsN6qR7wwkEib5NsLq63 t+BFZcJbpl2un0XK6fMUKZfoBiw0rPYyfCgcAwoV0LbKdHchdaOFyRc2Jx/Zv6FQL2wg oMv9zMbF3E4Jih8FWs3NncMHo7qdEVIyRTwiuy5kpvoCj1SjpzQQqArkbt+nGVPal2Oj oZkw== X-Gm-Message-State: AOAM533GASB3ta43s3M/picV9fOdGDaX47Lu5uunBOPcuOQq2tnuClVT 63iA++3PtMrytwxvQfSNzg== X-Google-Smtp-Source: ABdhPJxsM27XD7ZPQWtLllsk1BYtyuvELscHiUyd3+jcBCwwZewJhyhAgreQj/NwRclapQ9jfMzC2g== X-Received: by 2002:a05:6402:1f0b:b0:427:b390:2020 with SMTP id b11-20020a0564021f0b00b00427b3902020mr13987edb.70.1652466507506; Fri, 13 May 2022 11:28:27 -0700 (PDT) Received: from localhost.localdomain ([46.53.253.148]) by smtp.gmail.com with ESMTPSA id b1-20020a05640202c100b00427ae00972dsm1332354edx.12.2022.05.13.11.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 11:28:27 -0700 (PDT) Date: Fri, 13 May 2022 21:28:24 +0300 From: Alexey Dobriyan To: Andrew Morton Cc: Andy Shevchenko , Jagdish Gediya , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan.Cameron@huawei.com, rf@opensource.cirrus.com, pmladek@suse.com, ying.huang@intel.com, dave.hansen@intel.com Subject: Re: [PATCH v2 2/2] mm: Covert sysfs input to bool using kstrtobool() Message-ID: References: <20220426170040.65487-1-jvgediya@linux.ibm.com> <20220426170040.65487-2-jvgediya@linux.ibm.com> <20220512180537.5296f39b27c3488080ff67cf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220512180537.5296f39b27c3488080ff67cf@linux-foundation.org> X-Stat-Signature: e4jj3qygwswujdktkguuofs75azfwrd9 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Ju/51i1G"; spf=pass (imf31.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B23D5200AF X-HE-Tag: 1652466484-886107 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 12, 2022 at 06:05:37PM -0700, Andrew Morton wrote: > On Wed, 27 Apr 2022 18:17:29 +0300 Andy Shevchenko wrote: > > > On Tue, Apr 26, 2022 at 10:30:40PM +0530, Jagdish Gediya wrote: > > > Sysfs input conversion to corrosponding bool value e.g. "false" or "0" > > > to false, "true" or "1" to true are currently handled through strncmp > > > at multiple places. Use kstrtobool() to convert sysfs input to bool > > > value. > > > > ... > > > > > + if (kstrtobool(buf, &numa_demotion_enabled)) > > > return -EINVAL; > > > > Hmm... The commit message doesn't explain what's wrong with the error codes > > returned by kstrtobool(). Can't it be > > > > ret = kstrtobool(); > > if (ret) > > return ret; > > > > ? > > Jagdish fell asleep. > > Yes, I agree. It has no practical difference at present because > kstrtobool() can only return 0 or -EINVAL. I did this: ret = f(); if (ret) return ret; is slightly better because it doesn't require to load EINVAL into register: call f test eax, eax js 1f ... 1: ret