From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E20C433EF for ; Fri, 13 May 2022 18:12:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CFF26B0073; Fri, 13 May 2022 14:12:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 659516B0075; Fri, 13 May 2022 14:12:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3D96B0078; Fri, 13 May 2022 14:12:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3534C6B0073 for ; Fri, 13 May 2022 14:12:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0D819327C1 for ; Fri, 13 May 2022 18:12:49 +0000 (UTC) X-FDA: 79461515658.15.C0E3E0A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 7E79C1800BB for ; Fri, 13 May 2022 18:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PDoRf50/2prdMwiGzu9XwiSUsoeLHlgrKt3Aw5ZPQ7k=; b=cfRcQokCSVzkWsZBWMU83zH0Xu QA3j9BbAzGUp/vJ6qO9qTaoN1b7lBwVzT9WgjFQftAXkH0MyCRysSbmP/hQLW6Dr3RIJEUgObkRfv 1t+Z4WWSIhe+cYbIp7Q0TXE+rAgdvLCKqNI4ix2oBw4VV/iW/h5ug1P++M2WWYIX0zdILfUPom6Dl yyb2nNRO1XGVsucWQMOmkw4++IrZZZVmf4QTvudZ0doxGklQgrkSwWG3TZDCG0RwvAE0rCZCDy4fr 69QYjJU9ez0IKzl3NarDe7ak7pe5eW+iVnMd3WewGAd5d0LsFJDiG54rzLxvRthpc8KZt7tpM+m8F dcEPmvLw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1npZm9-007Yds-UH; Fri, 13 May 2022 18:12:29 +0000 Date: Fri, 13 May 2022 19:12:29 +0100 From: Matthew Wilcox To: Hsin-Yi Wang Cc: Xiongwei Song , Phillip Lougher , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , Linus Torvalds , "Song, Xiongwei" , "linux-mm@kvack.org" , "squashfs-devel@lists.sourceforge.net" Subject: Re: squashfs performance regression and readahea Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cfRcQokC; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7E79C1800BB X-Rspam-User: X-Stat-Signature: brcj5ofae4ch8k1dckojym7xqi9fxpaa X-HE-Tag: 1652465565-115979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 14, 2022 at 12:43:47AM +0800, Hsin-Yi Wang wrote: > > One stupid question, see below code from your patch: > > > > + } > > + > > + kfree(actor); > > + return; > > + > > +skip_pages: > > > > when release page pointers array after pages cached? I don't see > > any chance to do that. > > > actor is not a page pointer. This is allocated from > squashfs_page_actor_init() and should be freed after use. Or do you > mean skip_pages? There are some situations where we can't decompress > the whole block, so we will skip those pages. I think the concern is that you don't seem to kfree(pages) on this exit path.