From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3868C433FE for ; Fri, 29 Apr 2022 12:13:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60F836B0071; Fri, 29 Apr 2022 08:13:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BDD86B0073; Fri, 29 Apr 2022 08:13:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AC7B6B0074; Fri, 29 Apr 2022 08:13:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 3A6226B0071 for ; Fri, 29 Apr 2022 08:13:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 08D792ACE0 for ; Fri, 29 Apr 2022 12:13:10 +0000 (UTC) X-FDA: 79409806140.21.2A5B94F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf29.hostedemail.com (Postfix) with ESMTP id B4EEB12006C for ; Fri, 29 Apr 2022 12:13:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0A975B83453; Fri, 29 Apr 2022 12:13:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39947C385A7; Fri, 29 Apr 2022 12:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651234385; bh=jw3d4LjLrONS5HEaxrtjgz2gOcFZwXgKxK34kfuT4Fo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cuaxore1r67I0zMIAh5pfZjIzO8Mw3KTAeSh0/X2rmMZWK+F6NQQnlz7gSV20veKC 7aUzCdcz3ur6BsW+hQHcRVS/oS3cX1Tp5bfJjCRbKdiMtl9g1+35n/D3kYP+yx7oSx Pz3POg2/Nv/zv2inYg+xG+eumP5KQS1IqXRX5qtg= Date: Fri, 29 Apr 2022 14:13:02 +0200 From: Greg Kroah-Hartman To: Sean Christopherson Cc: Hugh Dickins , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A. Shutemov" , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, Sasha Levin , Paolo Bonzini Subject: Re: [PATCH AUTOSEL 13/14] mm/thp: ClearPageDoubleMap in first page_add_file_rmap() Message-ID: References: <20220428154222.1230793-1-gregkh@linuxfoundation.org> <20220428154222.1230793-13-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B4EEB12006C X-Stat-Signature: u9g1wfpcy8xt4nr878osfp598nqm54s1 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=cuaxore1; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf29.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1651234385-418334 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 28, 2022 at 10:45:18PM +0000, Sean Christopherson wrote: > +Sasha and Paolo > > On Thu, Apr 28, 2022, Hugh Dickins wrote: > > On Thu, 28 Apr 2022, Greg Kroah-Hartman wrote: > > > On Thu, Apr 28, 2022 at 09:51:58AM -0700, Hugh Dickins wrote: > > > > On Thu, 28 Apr 2022, Greg Kroah-Hartman wrote: > > > > > > > > > From: Hugh Dickins > > > > > > > > > > commit bd55b0c2d64e84a75575f548a33a3dfecc135b65 upstream. > > > > > > > > > > PageDoubleMap is maintained differently for anon and for shmem+file: the > > > > > shmem+file one was never cleared, because a safe place to do so could > > > > > not be found; so it would blight future use of the cached hugepage until > > > > > evicted. > > > > > > > > > > See https://lore.kernel.org/lkml/1571938066-29031-1-git-send-email-yang.shi@linux.alibaba.com/ > > > > > > > > > > But page_add_file_rmap() does provide a safe place to do so (though later > > > > > than one might wish): allowing testing to return to an initial state > > > > > without a damaging drop_caches. > > > > > > > > > > Link: https://lkml.kernel.org/r/61c5cf99-a962-9a25-597a-53ab1bd8fbc0@google.com > > > > > Fixes: 9a73f61bdb8a ("thp, mlock: do not mlock PTE-mapped file huge pages") > > > > > Signed-off-by: Hugh Dickins > > > > > Reviewed-by: Yang Shi > > > > > Cc: "Kirill A. Shutemov" > > > > > Signed-off-by: Andrew Morton > > > > > Signed-off-by: Linus Torvalds > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > > > NAK. > > > > > > > > I thought we had a long-standing agreement that AUTOSEL does not try > > > > to add patches from akpm's tree which had not been marked for stable. > > > > > > True, this was my attempt at saying "hey these all look like they should > > > go to stable trees, why not?" > > > > Okay, it seems I should have read "AUTOSEL" as "Hey, GregKH here, > > these all look like they should go to stable trees, why not?", > > which would have drawn a friendlier response. > > FWIW, Sasha has been using MANUALSEL for the KVM tree to solicit an explicit ACK > from Paolo for these types of patches. AFAICT, it has been working quite well. Yes, that is what I should have put here, sorry about that. These were manually picked by me and I am asking if they should be included or not. I'll resend after dropping Hugh's patches from the series. thanks, greg k-h