From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65658C433EF for ; Thu, 28 Apr 2022 22:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 750876B0071; Thu, 28 Apr 2022 18:45:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D8046B0072; Thu, 28 Apr 2022 18:45:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 529BE6B0073; Thu, 28 Apr 2022 18:45:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 3E3356B0071 for ; Thu, 28 Apr 2022 18:45:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 118C52A206 for ; Thu, 28 Apr 2022 22:45:24 +0000 (UTC) X-FDA: 79407770568.06.FA67411 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf06.hostedemail.com (Postfix) with ESMTP id 3AB6518005B for ; Thu, 28 Apr 2022 22:45:22 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id bo5so5444548pfb.4 for ; Thu, 28 Apr 2022 15:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AqP7wSbo7WSzSy4l6HYEqupzMjO7gFTkhIq2MzyNb0A=; b=JqDgqAkqxRfNNLmqV0twQnowQWIPaTFVuaA6ZtSE2/W9+7fCBmVrEfYajEb2YLBSLl FLK4CRbHHZ7Adr96TTRTSNLbqFpTqCm7lDaCsi+ReAeevvlfLijXIIlJHigrlO3hAWxH 9EpDd9RGsANOfddzRbR+hpqBrPEqHTT7QYWnYEaqkBdZ10YQaukl3uZrWNJqv34AEams bj+/Y7gd5kuuqZ9mbAxfsdfhb7PnR7I84PbvfJeEF0ZN22JHRTnofBOZ6YxtLY+84DS8 wm8xYzPO7IECkoYW9eMr9CEEIgSONOgWiY8dURFPl9tPSea7arRJiDHQU09dGvY3WFnz ivIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AqP7wSbo7WSzSy4l6HYEqupzMjO7gFTkhIq2MzyNb0A=; b=5hl8dHYR70WvAY479iI+nfYzgC6LQBdntxFMElbR4GXqFXdgzzr3260z9SP5xEzpWb nDqLjaDwmMxmESsmQVsMDDA7qRnT6hUndRjsSB1hJyzLg79nvnl85FEYwX185pXceRXw CwDd9IAeDwq7PjLartOJ9Z75ybaKbOJ/H0fhe/5Y58XRZXhc2UzBpKlorr9c4nXXsb96 AUKg/wkTVvQGpCqcJXCfUo6y21x1ibndvPs2nCr6rm4HFbHuDvO4JZV8w5YGUqUJz+pY 7fRQ9ziqTv97k/zVbbgWlGRDr3TsV7SKuxFAT/KOVBa3BOYEmLjNqTOmGgqwkkVxXjOx yOSQ== X-Gm-Message-State: AOAM532e8DiH50dy9hglc7d/GqJknj1NbFalPOBnmIJu82NEI/EifcwH qrgPk9IXtEv8vPAlJSDXsU+ctQ== X-Google-Smtp-Source: ABdhPJwsExo1O7NKf8dvwXFhJjc/mnTP4ZYbb9E59TysQme5AwpU/tMHJ2sr1oRhM5YRyDB3LjC4pg== X-Received: by 2002:a05:6a00:190f:b0:50d:8b82:cb90 with SMTP id y15-20020a056a00190f00b0050d8b82cb90mr8179971pfi.65.1651185922372; Thu, 28 Apr 2022 15:45:22 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id n14-20020a17090a394e00b001d5f22845bdsm11955505pjf.1.2022.04.28.15.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 15:45:21 -0700 (PDT) Date: Thu, 28 Apr 2022 22:45:18 +0000 From: Sean Christopherson To: Hugh Dickins Cc: Greg Kroah-Hartman , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A. Shutemov" , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, Sasha Levin , Paolo Bonzini Subject: Re: [PATCH AUTOSEL 13/14] mm/thp: ClearPageDoubleMap in first page_add_file_rmap() Message-ID: References: <20220428154222.1230793-1-gregkh@linuxfoundation.org> <20220428154222.1230793-13-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3AB6518005B X-Stat-Signature: 8grcw5bfy8rexdmwq1c31g7xkh8rqqhp X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JqDgqAkq; spf=pass (imf06.hostedemail.com: domain of seanjc@google.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam09 X-HE-Tag: 1651185922-68732 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +Sasha and Paolo On Thu, Apr 28, 2022, Hugh Dickins wrote: > On Thu, 28 Apr 2022, Greg Kroah-Hartman wrote: > > On Thu, Apr 28, 2022 at 09:51:58AM -0700, Hugh Dickins wrote: > > > On Thu, 28 Apr 2022, Greg Kroah-Hartman wrote: > > > > > > > From: Hugh Dickins > > > > > > > > commit bd55b0c2d64e84a75575f548a33a3dfecc135b65 upstream. > > > > > > > > PageDoubleMap is maintained differently for anon and for shmem+file: the > > > > shmem+file one was never cleared, because a safe place to do so could > > > > not be found; so it would blight future use of the cached hugepage until > > > > evicted. > > > > > > > > See https://lore.kernel.org/lkml/1571938066-29031-1-git-send-email-yang.shi@linux.alibaba.com/ > > > > > > > > But page_add_file_rmap() does provide a safe place to do so (though later > > > > than one might wish): allowing testing to return to an initial state > > > > without a damaging drop_caches. > > > > > > > > Link: https://lkml.kernel.org/r/61c5cf99-a962-9a25-597a-53ab1bd8fbc0@google.com > > > > Fixes: 9a73f61bdb8a ("thp, mlock: do not mlock PTE-mapped file huge pages") > > > > Signed-off-by: Hugh Dickins > > > > Reviewed-by: Yang Shi > > > > Cc: "Kirill A. Shutemov" > > > > Signed-off-by: Andrew Morton > > > > Signed-off-by: Linus Torvalds > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > NAK. > > > > > > I thought we had a long-standing agreement that AUTOSEL does not try > > > to add patches from akpm's tree which had not been marked for stable. > > > > True, this was my attempt at saying "hey these all look like they should > > go to stable trees, why not?" > > Okay, it seems I should have read "AUTOSEL" as "Hey, GregKH here, > these all look like they should go to stable trees, why not?", > which would have drawn a friendlier response. FWIW, Sasha has been using MANUALSEL for the KVM tree to solicit an explicit ACK from Paolo for these types of patches. AFAICT, it has been working quite well.