From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0596C433EF for ; Thu, 28 Apr 2022 11:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16AC86B0071; Thu, 28 Apr 2022 07:30:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11B476B0072; Thu, 28 Apr 2022 07:30:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F25C96B0073; Thu, 28 Apr 2022 07:30:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id E38E36B0071 for ; Thu, 28 Apr 2022 07:30:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C59CB2A2D7 for ; Thu, 28 Apr 2022 11:30:45 +0000 (UTC) X-FDA: 79406070450.02.6BBFE4B Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf29.hostedemail.com (Postfix) with ESMTP id 2F17012006A for ; Thu, 28 Apr 2022 11:30:42 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id x52so2440125pfu.11 for ; Thu, 28 Apr 2022 04:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=staRmhhoFTpyzY4bmoGFNp1v/Je4AKSeU0LxuCL4jDU=; b=hqHWSiUoHqyucL9B+7Xovyqujly0/ugOcnWDtDiN8oqihfAWB3RIpcDDXpM5jV15hg hTTlGPr3vXZRbJEmMPxe+48hchpbpDQzU9bfmKH90Q3gDCvNlq5F/Colly/UkdD2GC8h Z498WozUjhxAMqgWkj7eE/fObrJZXKE6RCpmtDvuQmmQ0u2C/rrZg4VSC+uU8OpHYk3p EiGnC1lTGNxR81i2k0/0bNLq6rY0x5G1fLV4zpQ6NuW/MfiWfB84djujM1Bgn06h86dG fhKx8kxM5BPben913+t8OLYYFey76abD2FhmjWoh7/ZQ9G9kcTs37BXGHUdTf2iCoTwq dDFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=staRmhhoFTpyzY4bmoGFNp1v/Je4AKSeU0LxuCL4jDU=; b=s1rh7Yu1dW7Kwvfaxn24epzXVv5+jdYrZ3rw+OtUR9Nmu2pypOnQFtndXGfAj8MZAn +L4INedwi/Xoe2Jkfknsh+OR41FzzWH6whust5wnJUTgKnl8JUhCjm3OJgmUTC5cHCHX guewPiZU4+N7FlLjKOi8ix2nBjfSyiFGJeOLa6QWry3x8KucGbS1qMUA76wWnKPw+pX0 9rdE5KtaCJBEeaJuhz7vImliC3oyBvMx2AHNXPUiZb+xOxLRYDtRRg4zD5EfPN88weJk qSTD7NdmEqEi1q1RIQ0bEALkR8PRQBPIJP4QWXXQNj0JHWPtouujJ4CWxn8h02ed92bA VO0w== X-Gm-Message-State: AOAM530IWxTQ4gRDuVIa6HuboPFM3VFf+XT2rrk0JderHDnvj+Myd2DN +3oZjQjTjkjLO/qaR/GhEMA= X-Google-Smtp-Source: ABdhPJy4d74zijQjqs1W8GNyLpfUWDBftTGBf+gvoOKVYW1Ym1+35cJ3dEQgQPDvWNhrYz0i3Hx9MQ== X-Received: by 2002:a05:6a00:1908:b0:4f7:8813:b2cb with SMTP id y8-20020a056a00190800b004f78813b2cbmr34479446pfi.54.1651145444215; Thu, 28 Apr 2022 04:30:44 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id w123-20020a623081000000b005056a4d71e3sm22029839pfw.77.2022.04.28.04.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 04:30:43 -0700 (PDT) Date: Thu, 28 Apr 2022 20:30:36 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Joe Perches Cc: Vlastimil Babka , Marco Elver , Matthew WilCox , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/23] mm/slab_common: cleanup kmalloc() Message-ID: References: <20220414085727.643099-1-42.hyeyoo@gmail.com> <20220414085727.643099-13-42.hyeyoo@gmail.com> <50118b134e9495c5264adf62d998a5c5386d6a55.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50118b134e9495c5264adf62d998a5c5386d6a55.camel@perches.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2F17012006A Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hqHWSiUo; spf=pass (imf29.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Stat-Signature: 38jst19578mkn3a1pi37t1c8pp939mwc X-HE-Tag: 1651145442-781276 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 11:00:32AM -0700, Joe Perches wrote: > On Thu, 2022-04-14 at 17:57 +0900, Hyeonggon Yoo wrote: > > Now that kmalloc() and kmalloc_node() do same job, make kmalloc() > > wrapper of kmalloc_node(). > > Why make every kmalloc larger object code size ? > > What is the overall object size change in a typical defconfig ? Thank you for pointing this. It increases every call to kmalloc() is increased (+5 bytes) due to passing NUMA_NO_NODE. on x86_64's defconfig, the difference of vmlinux size is not that visible because this patch also removes tracepoint. But yeah, increasing 5 bytes for every caller seems questionable. I'll think about this for a bit :) Thanks! -- Thanks, Hyeonggon