From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521ABC433F5 for ; Thu, 28 Apr 2022 02:56:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 867156B0071; Wed, 27 Apr 2022 22:56:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 817FD6B0072; Wed, 27 Apr 2022 22:56:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DE836B0073; Wed, 27 Apr 2022 22:56:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 5CC276B0071 for ; Wed, 27 Apr 2022 22:56:05 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1F15E1001 for ; Thu, 28 Apr 2022 02:56:05 +0000 (UTC) X-FDA: 79404773490.26.D84DE2B Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf12.hostedemail.com (Postfix) with ESMTP id 5281940046 for ; Thu, 28 Apr 2022 02:55:54 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id q8so3176985plx.3 for ; Wed, 27 Apr 2022 19:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IvwH9xbsu6FeuNLim9woHWyD9ldcfxEbIcF/eG8AgJw=; b=P2vJUR2qlxWOLpkcSYZd+hHtix4PhqAD8cPpOe1GZUsDrWejpdCJqLq6253y0W/c6y CO7ZAQH/Kxad7GkOY41UiVo3bOCYQ+VnBNeTRk18ZMjx6bzwiJNzUTfOK1KXgi8K3XF/ VNiXmoLsEdrPKIY0TvEJWDVDu0G7LBJh1BMSPxX0ZeTG+LixGXrW2pgvLo2Jh5CU8tBY 4SrVSVLPxy85LskI7qAZkuXtyAG+vAPb6OPfV/aa6Nvq6tpFegpoDK75XMqqUE6j/osV t0NVdb3KjKJaVbkGJ98KigDHRRIMCdkPqkhaY7Icr+7GaOY0FX/a4BEhGBv1CvyBhPLn On9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IvwH9xbsu6FeuNLim9woHWyD9ldcfxEbIcF/eG8AgJw=; b=1oGBdYnpGqztUbXB6MO94lHrpX6n++DKeYd8hD/+9Xl7ICYS1evq+bU5WhEarJh8TQ /PCZHrvb2HU9XTR8crGx5w1l5Hrb5CvxLgiENwkY1PZN+CR5Mvxv1kbirX8rzsmbnYDU bgIystXYe+Focfu/Gw0umTOaKewsj6rMzVMpJIJHBkJClLt3f/F+8lR2jfv4SNA2r+MK nSde0+szNQvFGg6kt7DvV/hN2bs8wxGZpYbfhEp+gA1j/LlRFRL/K5LP4ig1RI3xSglj Ob2iu2CoaOc20aljrutrnGFZSHFlv782kfLI7M3j1/VE+LtiQd1Z2gIj7caBbUmoSVom e95A== X-Gm-Message-State: AOAM530+9McZXPkGgBgRf8+PYzsNcl+SA71JckioLOWZlS7UMtuW8uVg W7MfBKd6D7UJB1HXQNJmQdwtLw== X-Google-Smtp-Source: ABdhPJy1ESR8MK5eh/CTeJwke24+N9wQZVarAEzXV+tdbYLw16YrJcUNcoHvMx8HVxPNgTxxTtbXvg== X-Received: by 2002:a17:90b:1d85:b0:1d9:c22a:e8c with SMTP id pf5-20020a17090b1d8500b001d9c22a0e8cmr10934560pjb.211.1651114562750; Wed, 27 Apr 2022 19:56:02 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id p27-20020a056a000a1b00b004f3f63e3cf2sm23472856pfh.58.2022.04.27.19.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 19:56:02 -0700 (PDT) Date: Thu, 28 Apr 2022 10:55:59 +0800 From: Muchun Song To: Baolin Wang Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, almasrymina@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] mm: hugetlb: Considering PMD sharing when flushing cache/TLBs Message-ID: References: <0443c8cf20db554d3ff4b439b30e0ff26c0181dd.1651056365.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0443c8cf20db554d3ff4b439b30e0ff26c0181dd.1651056365.git.baolin.wang@linux.alibaba.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5281940046 X-Stat-Signature: p4xrfbg768n8tq1sx1r3p7bm846rt6dp X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=P2vJUR2q; spf=pass (imf12.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1651114554-229383 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 06:52:05PM +0800, Baolin Wang wrote: > When moving hugetlb page tables, the cache flushing is called in > move_page_tables() without considering the shared PMDs, which may > be cause cache issues on some architectures. > > Thus we should move the hugetlb cache flushing into > move_hugetlb_page_tables() with considering the shared PMDs ranges, > calculated by adjust_range_if_pmd_sharing_possible(). Meanwhile also > expanding the TLBs flushing range in case of shared PMDs. > > Note this is discovered via code inspection, and did not meet a real > problem in practice so far. > > Fixes: 550a7d60bd5e ("mm, hugepages: add mremap() support for hugepage backed vma") > Signed-off-by: Baolin Wang > Reviewed-by: Mike Kravetz LGTM. Reviewed-by: Muchun Song Thanks.