From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B609BC433F5 for ; Wed, 27 Apr 2022 21:10:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FB016B0071; Wed, 27 Apr 2022 17:10:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AAD56B0073; Wed, 27 Apr 2022 17:10:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224366B0074; Wed, 27 Apr 2022 17:10:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 142DA6B0071 for ; Wed, 27 Apr 2022 17:10:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CBAF1619CD for ; Wed, 27 Apr 2022 21:10:37 +0000 (UTC) X-FDA: 79403902914.26.90C92F1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 1759D1A004B for ; Wed, 27 Apr 2022 21:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651093836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KxmZt3wU1oEAv1rqVqfACLQCWXEoiK5iilWdgxf36ic=; b=OavqWnX9ub9rz2eXgAIy7SOyHlWxtigvETVYqbLeiaWBQIDl/4Bm4YmjkEC5uAVi/j1o7b vW6MtlnaJ7lNDi4/ckq/wuBidyqtpECxUCFUjAo5TP3K1WSfkoKLV9B2FnLKqE1IoCOwiI sWezH+KmVErhmMwOZioCbHX4ZF1xGzo= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-265-VfVhmY_IO4Kv9izMJ3MWZg-1; Wed, 27 Apr 2022 17:10:35 -0400 X-MC-Unique: VfVhmY_IO4Kv9izMJ3MWZg-1 Received: by mail-il1-f200.google.com with SMTP id m11-20020a056e020deb00b002cbde7e7dcfso646347ilj.2 for ; Wed, 27 Apr 2022 14:10:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KxmZt3wU1oEAv1rqVqfACLQCWXEoiK5iilWdgxf36ic=; b=QGot7rMoP3o47zlR/EoWsjcCy35EOjUTBKLxMMKchpZt+HergYR93Qbo26ZFeljHTm 9pjonyHuVIZkMdWrRK9xwsyKEXmc961ynlRAbgw9FbLk5GZM3PqoNPEIDCJzulZgp9dM KbpGS4OhdvbnrvRre8Lyu3jCKDpdu9lAiiAYxtcVjZLDD9GhKVlsA4jQ6yWHMWhyILG2 I4/lMPpdN9GfzPdnCxNCgiWxxs9GhqoIrkK7KYjA2sdy8K1EwMmkkyuQnZuCO1GMxEdn agh8+DKUZNkKUVhV4WsUVxGX+c5KfmCEfM3OxRUx6nWwH/kCma0pp8fa1qr24QEyTIxT sn9g== X-Gm-Message-State: AOAM531xP51voBF8YWYnXt/GNzzv9ptcKiBvkK2IYNRnJV0Mmd9KY7zw Xy/Fs91fx8jbTca3KyxfAOXpjor2xQa8bD5zPK+/qjEkHYnvp5RU+adnxPhuD4fKAKKpWolT3PV YogFLHk6R9to= X-Received: by 2002:a05:6638:cd3:b0:32a:eec5:bbca with SMTP id e19-20020a0566380cd300b0032aeec5bbcamr7655213jak.99.1651093834914; Wed, 27 Apr 2022 14:10:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd/6YzCzmSt4LwoKzT5FAZHkhtKitmJCODyyJA6yreK4jj0bB0I5tXWJ1TjGP6o/68rFm93A== X-Received: by 2002:a05:6638:cd3:b0:32a:eec5:bbca with SMTP id e19-20020a0566380cd300b0032aeec5bbcamr7655178jak.99.1651093834702; Wed, 27 Apr 2022 14:10:34 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id y4-20020a92d0c4000000b002cd8a7db5f5sm7361931ila.11.2022.04.27.14.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 14:10:34 -0700 (PDT) Date: Wed, 27 Apr 2022 17:10:31 -0400 From: Peter Xu To: Zach O'Keefe Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer , kernel test robot Subject: Re: [PATCH v3 06/12] mm/khugepaged: remove khugepaged prefix from shared collapse functions Message-ID: References: <20220426144412.742113-1-zokeefe@google.com> <20220426144412.742113-7-zokeefe@google.com> MIME-Version: 1.0 In-Reply-To: <20220426144412.742113-7-zokeefe@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: xgis998duh164fcaqkna6fxctso14ukz X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1759D1A004B Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OavqWnX9; spf=none (imf19.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-HE-Tag: 1651093832-272771 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 07:44:06AM -0700, Zach O'Keefe wrote: > The following functions/tracepoints are shared between khugepaged and > madvise collapse contexts. Remove the khugepaged prefixes. > > tracepoint:mm_khugepaged_scan_pmd -> tracepoint:mm_scan_pmd > khugepaged_test_exit() -> test_exit() > khugepaged_scan_abort() -> scan_abort() > khugepaged_scan_pmd() -> scan_pmd() > khugepaged_find_target_node() -> find_target_node() The khugepaged prefix can indeed be confusing, but are the new names just too short? IMHO it'll be nice to still have some generic prefix. Perhaps something like "hpage_collapse_"/"hpage_"/"hpc_"/..? -- Peter Xu