From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D03C433EF for ; Wed, 27 Apr 2022 21:13:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C84C86B0071; Wed, 27 Apr 2022 17:13:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C335F6B0073; Wed, 27 Apr 2022 17:13:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD3666B0074; Wed, 27 Apr 2022 17:13:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 9D8B66B0071 for ; Wed, 27 Apr 2022 17:13:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 70B67292A7 for ; Wed, 27 Apr 2022 21:13:02 +0000 (UTC) X-FDA: 79403909004.12.BDC1A1E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 38C352004E for ; Wed, 27 Apr 2022 21:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651093981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4xk2yghO3ZGXvma56W3G8dzp3i6jQW6l/WRH95pht1s=; b=JuwHG4LNrZU7QYOknf+IcQCKJd5Z+cWbYYcCqAteJqCbD4iIndC8ZVzBwq2UrYJmSUCtPC 0NzI2bKTuU5ZvihCE7s3d24W7GTFHz/EcV6V1meCCiy0+rvIddM4V49fDF5944Tui63w6b UpS4uZ6MVmpKCfjdH9AoAu5zII3r8RE= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-153-d0D1to-JO5ux_fikztjhrw-1; Wed, 27 Apr 2022 17:13:00 -0400 X-MC-Unique: d0D1to-JO5ux_fikztjhrw-1 Received: by mail-io1-f71.google.com with SMTP id y10-20020a056602164a00b00653f388e244so3141850iow.22 for ; Wed, 27 Apr 2022 14:13:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4xk2yghO3ZGXvma56W3G8dzp3i6jQW6l/WRH95pht1s=; b=iZctUUMMH6RYCgMHxSNPBS3xmMPLnScj4i/UmF0/bMaxku8oFqwRDwMab3B69uH2nQ FxQCA8QSn0JejlIhvZLB7LYD+dv1T4OCl/KS3SmI92Nys3EZ1yQm+6ofIOXW7xr5pqJe qWOqxVipBdj/EFHjkbFkJgatND8qHIo4TyNlJE2roOxduOE94EEjVpaEgfLYpbPCsaVJ xAYRp815MLfGd9JZJtFPfQweWFxXdh5yPSIxCbspR624CuikAp9p9AZHZlIZvBXqxVXZ r9ZObmTK26nJdzyDMeayLQcIyiz6NKL+Zi8o67W0iZ2MQ4fVM/dNncbkFRGEyrfucsNI H33w== X-Gm-Message-State: AOAM530XpVeCkyKB+Re9TsEKtQFwmhYG0JZ5qKD19Ni03Fqi6xacGmSb 3J/+BKzbDPWfkfUDQcn2uT3rTXBh5d0kdGCcFhNPvLqUT/3bL3aUOkOnN6CIeSzQS+CV1cvxEE1 OMsKijH2KYYc= X-Received: by 2002:a92:bf06:0:b0:2c9:b21d:6db7 with SMTP id z6-20020a92bf06000000b002c9b21d6db7mr11882720ilh.222.1651093979701; Wed, 27 Apr 2022 14:12:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzo+Pyoi8J5AC79bwA6iowPTRhASfHl9tm2WJPWqxjfHAHydRyTTWjiOukqGSMSd2l1hONjeQ== X-Received: by 2002:a92:bf06:0:b0:2c9:b21d:6db7 with SMTP id z6-20020a92bf06000000b002c9b21d6db7mr11882706ilh.222.1651093979446; Wed, 27 Apr 2022 14:12:59 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id a9-20020a926609000000b002ca50234d00sm10182704ilc.2.2022.04.27.14.12.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 14:12:59 -0700 (PDT) Date: Wed, 27 Apr 2022 17:12:56 -0400 From: Peter Xu To: Zach O'Keefe Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer Subject: Re: [PATCH v3 07/12] mm/khugepaged: add flag to ignore khugepaged_max_ptes_* Message-ID: References: <20220426144412.742113-1-zokeefe@google.com> <20220426144412.742113-8-zokeefe@google.com> MIME-Version: 1.0 In-Reply-To: <20220426144412.742113-8-zokeefe@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 38C352004E Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JuwHG4LN; spf=none (imf03.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Stat-Signature: himij143b8k3zeof5af4zj69w8ezykrd X-HE-Tag: 1651093978-821036 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 07:44:07AM -0700, Zach O'Keefe wrote: > @@ -2365,6 +2375,7 @@ static int khugepaged(void *none) > { > struct mm_slot *mm_slot; > struct collapse_control cc = { > + .enforce_pte_scan_limits = true, > .last_target_node = NUMA_NO_NODE, > .gfp = &alloc_hugepage_khugepaged_gfpmask, > .alloc_hpage = &khugepaged_alloc_page, > @@ -2512,6 +2523,7 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > unsigned long start, unsigned long end) > { > struct collapse_control cc = { > + .enforce_pte_scan_limits = false, > .last_target_node = NUMA_NO_NODE, > .hpage = NULL, > .gfp = &alloc_hugepage_madvise_gfpmask, This changes the semantics of the new madvise(). IMHO it'll be ideal if this patch is moved before the introduction of MADV_COLLAPSE, so the new madvise() will have a consistent behavior. -- Peter Xu