From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6617C433EF for ; Wed, 27 Apr 2022 15:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F7B46B0072; Wed, 27 Apr 2022 11:42:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A5DC6B0073; Wed, 27 Apr 2022 11:42:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 395576B0074; Wed, 27 Apr 2022 11:42:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 2B8A56B0072 for ; Wed, 27 Apr 2022 11:42:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E58BC28BEA for ; Wed, 27 Apr 2022 15:42:39 +0000 (UTC) X-FDA: 79403076438.19.0D62311 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf28.hostedemail.com (Postfix) with ESMTP id 2BB10C0048 for ; Wed, 27 Apr 2022 15:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651074159; x=1682610159; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XUPw6zKcEmTgJvPIDxaK2dswQjcD22fWJPyux4y0Zso=; b=NXJqjddw/TG4iCTq22mtchepgjHjirwjRh0CfMfZ5UG1q+WOS9Ztaep7 lccpFQ7IqQ1oTLkZ9ZB8SYQ+1BHM49wIsW/4mm/KgWvXTi6sHyaFjDhxL 3S0DuF7jgB/PPU/eqqsClLpOfRYvGZKEoVVWDV/8ZoRwaXlybpY7bck8M nsJhnUA2iT0ULxo2mGp+pOCEPFfrmJ+Q9DMVrgbNMs5RYi2tYPNIj6gRv llxxMlZC4DIEdqjKxug/tc6MEya/WAfhqXZVF4rPGH7MsqVsMYKYiKpNf 6YIeGs2UQFMJr3J5hDmzpmsn6cndq+ld3QEh4HHsEWKH+AqwetdOPBPnS w==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="247898791" X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; d="scan'208";a="247898791" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 08:17:35 -0700 X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; d="scan'208";a="680829030" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 08:17:32 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1njjQ1-008sao-CJ; Wed, 27 Apr 2022 18:17:29 +0300 Date: Wed, 27 Apr 2022 18:17:29 +0300 From: Andy Shevchenko To: Jagdish Gediya Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan.Cameron@huawei.com, adobriyan@gmail.com, akpm@linux-foundation.org, rf@opensource.cirrus.com, pmladek@suse.com, ying.huang@intel.com, dave.hansen@intel.com Subject: Re: [PATCH v2 2/2] mm: Covert sysfs input to bool using kstrtobool() Message-ID: References: <20220426170040.65487-1-jvgediya@linux.ibm.com> <20220426170040.65487-2-jvgediya@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426170040.65487-2-jvgediya@linux.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2BB10C0048 X-Stat-Signature: fz9jjbjpai958f697ayzuu8kyokq5tad X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NXJqjddw; spf=none (imf28.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1651074150-739313 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 10:30:40PM +0530, Jagdish Gediya wrote: > Sysfs input conversion to corrosponding bool value e.g. "false" or "0" > to false, "true" or "1" to true are currently handled through strncmp > at multiple places. Use kstrtobool() to convert sysfs input to bool > value. ... > + if (kstrtobool(buf, &numa_demotion_enabled)) > return -EINVAL; Hmm... The commit message doesn't explain what's wrong with the error codes returned by kstrtobool(). Can't it be ret = kstrtobool(); if (ret) return ret; ? ... > + if (kstrtobool(buf, &enable_vma_readahead)) > return -EINVAL; Ditto. -- With Best Regards, Andy Shevchenko