From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A86C0C433EF for ; Wed, 27 Apr 2022 12:47:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E4A26B0071; Wed, 27 Apr 2022 08:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36D236B0072; Wed, 27 Apr 2022 08:47:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C0D46B0073; Wed, 27 Apr 2022 08:47:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 07A4B6B0071 for ; Wed, 27 Apr 2022 08:47:43 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D011620947 for ; Wed, 27 Apr 2022 12:47:42 +0000 (UTC) X-FDA: 79402635564.03.9CF5C3D Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf31.hostedemail.com (Postfix) with ESMTP id A9D1520057 for ; Wed, 27 Apr 2022 12:47:33 +0000 (UTC) Received: by mail-wm1-f45.google.com with SMTP id a14-20020a7bc1ce000000b00393fb52a386so2740920wmj.1 for ; Wed, 27 Apr 2022 05:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4ZU7ssA0uBUIH6XIuoYvcPvJ99ZnRQPUGmPQtpNi76c=; b=IW2c9joHq/hwifhAacbBVc1qzogNoXNAxtBDcYWCPJ6fPOM9y6yKnxL7LpTymyi1Mw hjMcixIyPI70Pi2PTqQlosHfCg1E8SnZ5l0ArWRvMWodQsPK5LhTsudvfWJN9kI4hau8 q0lDTsSvPRBac4hfb3TQ0orhvL6MUxOyjUvtvP5Yq/D4+mHZPSQn08XLD3G61YIjeSEa M4MO+l2LtH2/6N7jEwuGc9ZS+61BVh/gEjsKIastxGEQjzGbgP8+YNOkNsjzSS3tgsLX VM7ssK8zNESBLZCy1G0Aser5Eb5kq6GNeP6Wm6p+hwwD3361fyDBWfdauodf69g0q6sq eP3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4ZU7ssA0uBUIH6XIuoYvcPvJ99ZnRQPUGmPQtpNi76c=; b=BdyLaTU7YKX5C0TqMYcx1+UFbBKr4uIXL/fVVry3ITpx25Kc8v8g29BLEj3eT3lLYH YL+UrCQzUaQOeYx/pb/yngHTIaknCWRM+RbLzUgMT6858qSVD0XZAnVFOSa/CTw+dD8Q 072WJJniaWJtric+g4Yq8aUm2opinrkitJuTbMo9//f/ehvJUr2+tFfyD22w0TZaUDK+ vG91GfcmlrPtPUDDQFr8J8WlVx47u//iFStPdXGTMhRR+2o4fzBYPRRVHvilw2p4b86N +lh4n4mTsdYhsQ4P70ip3hK8+fCmZcqoe6WdGTvd8uRApML293dBwDh+INjIaM9p39RW CJbg== X-Gm-Message-State: AOAM533hLDSzMjQgMb8Zx15Y+D8piE6hblsPQScV1R4NC7/nhMaknc4H OUiQPl0JwiQK2Fb6+zyp2NnkMg== X-Google-Smtp-Source: ABdhPJz5NK+Ha567qr3bpxGvIn7U9ze3IwWfwIo5TY6HK+pg7ceZbULrFiJZ/aDUS4aMuFui3oFWlQ== X-Received: by 2002:a05:600c:1584:b0:38e:c80e:b8b5 with SMTP id r4-20020a05600c158400b0038ec80eb8b5mr34457739wmf.99.1651063660964; Wed, 27 Apr 2022 05:47:40 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:493f:cd0f:324a:323c]) by smtp.gmail.com with ESMTPSA id w12-20020adf8bcc000000b002060e3da33fsm13564171wra.66.2022.04.27.05.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 05:47:40 -0700 (PDT) Date: Wed, 27 Apr 2022 14:47:34 +0200 From: Marco Elver To: Alexander Potapenko Cc: Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/46] kasan: common: adapt to the new prototype of __stack_depot_save() Message-ID: References: <20220426164315.625149-1-glider@google.com> <20220426164315.625149-4-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426164315.625149-4-glider@google.com> User-Agent: Mutt/2.1.4 (2021-12-11) X-Rspamd-Queue-Id: A9D1520057 X-Stat-Signature: omr3ezcqpjj5njgdsapjnbk1mmo98p8a X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IW2c9joH; spf=pass (imf31.hostedemail.com: domain of elver@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam09 X-HE-Tag: 1651063653-939513 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 06:42PM +0200, Alexander Potapenko wrote: > Pass extra_bits=0, as KASAN does not intend to store additional > information in the stack handle. No functional change. > > Signed-off-by: Alexander Potapenko I think this patch needs to be folded into the previous one, otherwise bisection will be broken. > --- > Link: https://linux-review.googlesource.com/id/I932d8f4f11a41b7483e0d57078744cc94697607a > --- > mm/kasan/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index d9079ec11f313..5d244746ac4fe 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -36,7 +36,7 @@ depot_stack_handle_t kasan_save_stack(gfp_t flags, bool can_alloc) > unsigned int nr_entries; > > nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 0); > - return __stack_depot_save(entries, nr_entries, flags, can_alloc); > + return __stack_depot_save(entries, nr_entries, 0, flags, can_alloc); > } > > void kasan_set_track(struct kasan_track *track, gfp_t flags) > -- > 2.36.0.rc2.479.g8af0fa9b8e-goog >