From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB314C433EF for ; Tue, 26 Apr 2022 13:27:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DFFE6B0073; Tue, 26 Apr 2022 09:27:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 467DA6B0074; Tue, 26 Apr 2022 09:27:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E2B46B0075; Tue, 26 Apr 2022 09:27:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 1CE1C6B0073 for ; Tue, 26 Apr 2022 09:27:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E64874F4 for ; Tue, 26 Apr 2022 13:27:09 +0000 (UTC) X-FDA: 79399106178.30.F68905E Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf05.hostedemail.com (Postfix) with ESMTP id 8A7B210005E for ; Tue, 26 Apr 2022 13:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650979628; x=1682515628; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=d7bkgmZnJMhnPyUymkC1XeAvQ2myhgXmgRziaJNPH8Q=; b=dIF2/brDUt0m2/gjCFVBY1mLKcxJK5R3Fiu9m3NtySyn/qwqiKLJ8zbN S1Ri5+ingeoyenMghR98psYwma6TEYC8NHSs/mtU2P0XdDJc8qruLiSHN UFouFYIpb2y5mTlqLSUCqIO4DambKwPHzS4uht1oXRtVhION4i35OhaQL ngSu/nvCJ2OKOLueoKAILsHHAft9CUuzdZbwLsRfLf/OFc/ZOxEI8DE1J uavXZJl2leH9adpq5VdDVuqF6FmuePQBDijt4y+MrGh3XbZ1/FqfdMUTj FoN4en0vc6VQzlCR6r0o4x9xeI1CGyHxmFUUO2x6knyMa3GJzCcI0xYJd A==; X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="265740816" X-IronPort-AV: E=Sophos;i="5.90,290,1643702400"; d="scan'208";a="265740816" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 06:27:07 -0700 X-IronPort-AV: E=Sophos;i="5.90,290,1643702400"; d="scan'208";a="730248354" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 06:27:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1njLDa-008L8S-7M; Tue, 26 Apr 2022 16:27:02 +0300 Date: Tue, 26 Apr 2022 16:27:01 +0300 From: Andy Shevchenko To: Jagdish Gediya Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, dave.hansen@intel.com, Andrew Morton , Richard Fitzgerald , Petr Mladek Subject: Re: [PATCH v2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool Message-ID: References: <20220426064001.14241-1-jvgediya@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426064001.14241-1-jvgediya@linux.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Stat-Signature: kt3fdrtykswetrkjwhspm5ycywgzr5tf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8A7B210005E X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="dIF2/brD"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf05.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com X-HE-Tag: 1650979622-110598 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 12:10:01PM +0530, Jagdish Gediya wrote: > At many places in kernel, It is necessary to convert sysfs input > to corrosponding bool value e.g. "false" or "0" need to be converted > to bool false, "true" or "1" need to be converted to bool true, > places where such conversion is needed currently check the input > string manually, kstrtobool can be utilized at such places but kstrtobool() > currently kstrtobool doesn't have support to "false"/"true". Ditto. > Add "false"/"true" support to kstrtobool while string conversion Ditto. > to bool. Modify existing manual sysfs conversions to use kstrtobool(). > This patch doesn't have any functionality change. > Cc: Andrew Morton > Cc: Andy Shevchenko > Cc: Richard Fitzgerald > Cc: Petr Mladek You may use --cc parameter to `git send-email`. ... > lib/kstrtox.c | 7 +++++++ > mm/migrate.c | 6 +----- > mm/swap_state.c | 6 +----- Please, split to two. Also Documentation update is missed. -- With Best Regards, Andy Shevchenko