From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6A4C433EF for ; Tue, 26 Apr 2022 14:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9ABB86B0073; Tue, 26 Apr 2022 10:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95ADE6B0074; Tue, 26 Apr 2022 10:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FB8E6B0075; Tue, 26 Apr 2022 10:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 714A76B0073 for ; Tue, 26 Apr 2022 10:21:19 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 37A5160590 for ; Tue, 26 Apr 2022 14:21:19 +0000 (UTC) X-FDA: 79399242678.05.856A96D Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf06.hostedemail.com (Postfix) with ESMTP id 4645D180044 for ; Tue, 26 Apr 2022 14:21:17 +0000 (UTC) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23QCLlM0023199; Tue, 26 Apr 2022 14:21:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=nxJrjASpdOp6LZ/qybVuOqh2psHVAGqnrBLl9aVXjKA=; b=HYSjWqbO/0ZpplQhU+nBGOKMKnFGRxFRVfTcMgCO8ZPDmQ2QfTL18AbnG6cds+IDp5Wp JDnu5pJb9kg99vmPP3tzex6fo8PBNby+pMI7Xw1A8QOSRjNJOKmuooDE9BQ6V73vx0qb CFH2Bg+8u+l+4w68OmFza5d0I4xUfUy6OJFB9slM39zNj0E8MgSLuxJwSv15siF579v0 IdilRLo2gWqS/1+hBD0Hlf8pP1LHdET5JAwi9vpQJmql6qMGEaXdrEh0Z27yOM5PAWUq kZr5oAK6ChH3Rn1k5VqU+x79tuowNuyTsrU4Tg4rGw6L0pQs1KbZ9DC/CtaYcWC+V4JJ Qw== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fpgn7tsnx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Apr 2022 14:21:13 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23QE8QdI003317; Tue, 26 Apr 2022 14:21:11 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma06ams.nl.ibm.com with ESMTP id 3fm8qj4jms-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Apr 2022 14:21:11 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23QEL9ev39191026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Apr 2022 14:21:09 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 60CE5A4057; Tue, 26 Apr 2022 14:21:09 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2DB0BA4040; Tue, 26 Apr 2022 14:21:07 +0000 (GMT) Received: from li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com (unknown [9.43.82.112]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 26 Apr 2022 14:21:06 +0000 (GMT) Date: Tue, 26 Apr 2022 19:50:59 +0530 From: Jagdish Gediya To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, dave.hansen@intel.com, Andrew Morton , Richard Fitzgerald , Petr Mladek Subject: Re: [PATCH v2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool Message-ID: References: <20220426064001.14241-1-jvgediya@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: gwNlRMVl6-xaTSMX2znSEiv-oui1UpIa X-Proofpoint-ORIG-GUID: gwNlRMVl6-xaTSMX2znSEiv-oui1UpIa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-26_02,2022-04-26_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 clxscore=1015 mlxlogscore=902 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204260089 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4645D180044 X-Stat-Signature: 9c7wnszk8t394hpgcxyjk16a1qaye9g8 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HYSjWqbO; spf=pass (imf06.hostedemail.com: domain of jvgediya@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=jvgediya@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-HE-Tag: 1650982877-188072 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 04:27:01PM +0300, Andy Shevchenko wrote: > On Tue, Apr 26, 2022 at 12:10:01PM +0530, Jagdish Gediya wrote: > > At many places in kernel, It is necessary to convert sysfs input > > to corrosponding bool value e.g. "false" or "0" need to be converted > > to bool false, "true" or "1" need to be converted to bool true, > > places where such conversion is needed currently check the input > > string manually, kstrtobool can be utilized at such places but > > kstrtobool() > > > currently kstrtobool doesn't have support to "false"/"true". > > > Ditto. > > > Add "false"/"true" support to kstrtobool while string conversion > > Ditto. > > > to bool. Modify existing manual sysfs conversions to use kstrtobool(). > > > This patch doesn't have any functionality change. > > > Cc: Andrew Morton > > Cc: Andy Shevchenko > > Cc: Richard Fitzgerald > > Cc: Petr Mladek > > You may use --cc parameter to `git send-email`. Sure, Will remove these from here. > ... > > > lib/kstrtox.c | 7 +++++++ > > mm/migrate.c | 6 +----- > > mm/swap_state.c | 6 +----- > > Please, split to two. Sure > Also Documentation update is missed. I am not finding any related documentation. I can update the comment on the function for true/false change. --Jagdish > > >