From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62687C433EF for ; Mon, 25 Apr 2022 09:32:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E3786B0074; Mon, 25 Apr 2022 05:32:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 693936B0075; Mon, 25 Apr 2022 05:32:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 533866B007B; Mon, 25 Apr 2022 05:32:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 41AD96B0074 for ; Mon, 25 Apr 2022 05:32:27 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 026EF62FDE for ; Mon, 25 Apr 2022 09:32:26 +0000 (UTC) X-FDA: 79394885934.13.69A7DDA Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf02.hostedemail.com (Postfix) with ESMTP id 1AA1280049 for ; Mon, 25 Apr 2022 09:32:23 +0000 (UTC) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23P87Shb023705; Mon, 25 Apr 2022 09:32:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=uOxDMBWeLkg9WNZeIza4Ng+gLhOHcmfsuTeiM+dbGv4=; b=QpWuA09OcWwa95NDnpakN3mTdRJq4wCbQlJ8F3MG614EtcvjHYHPJSI+XD+bs0EUS2lv nG20LfkUUkljDqwVyqDvEP6FYwUfeO3H94yq5qK1UP1tI+NzzolE1pRbNX+wo5d1rUWY WRk4pGZWwEK6/fHnHcdm9UMYawzWvHxm2Sazg/MryeLrhQmYxqCxY9CcQI5qeF7P7KkK adGVW3+NvMqdt1+vwRhoCQnmxS7v0ma7yWhZcKjpjWZ/2Sbrk8LEJ99bTWIUSUAb/HYV ciNpI6FGTdhVxWZ8GDNrQqvrS+pglMSQEO+2KQGfCtdVx2V1pA0RcdpGGXnRwO/+RxkQ nA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3fmuh5vv2q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Apr 2022 09:32:24 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 23P9WNJT010970; Mon, 25 Apr 2022 09:32:23 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3fmuh5vv22-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Apr 2022 09:32:23 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23P9RLTB017445; Mon, 25 Apr 2022 09:32:21 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma03ams.nl.ibm.com with ESMTP id 3fm938t49u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Apr 2022 09:32:21 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23P9WIHZ58065256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Apr 2022 09:32:19 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E1A3A4C040; Mon, 25 Apr 2022 09:32:18 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 104394C044; Mon, 25 Apr 2022 09:32:16 +0000 (GMT) Received: from li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com (unknown [9.43.47.198]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 25 Apr 2022 09:32:15 +0000 (GMT) Date: Mon, 25 Apr 2022 15:02:08 +0530 From: Jagdish Gediya To: "ying.huang@intel.com" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, dave.hansen@linux.intel.com, aneesh.kumar@linux.ibm.com, shy828301@gmail.com, weixugc@google.com, gthelen@google.com, dan.j.williams@intel.com Subject: Re: [PATCH v3 1/7] mm: demotion: Fix demotion targets sharing among sources Message-ID: References: <20220422195516.10769-1-jvgediya@linux.ibm.com> <20220422195516.10769-2-jvgediya@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 58Me0xLUKT-80JlZi4j6SGJUVlIKy24Y X-Proofpoint-GUID: _4klCVE2yRjutZrfd7aIDoXua3OnRyrf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-25_05,2022-04-22_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204250040 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1AA1280049 X-Stat-Signature: pa5hkx1wa6yobqnfigf7j6cuicggsqs6 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QpWuA09O; spf=pass (imf02.hostedemail.com: domain of jvgediya@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=jvgediya@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-HE-Tag: 1650879143-396007 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 24, 2022 at 11:25:50AM +0800, ying.huang@intel.com wrote: > > Subject: [PATCH v3 1/7] mm: demotion: Fix demotion targets sharing among sources > > IMHO, this patch doesn't fix some bugs in the original code. Instead, > it just enhances the original code. For example, the subject could be, I think it is fixing a bug, there is a comment in the code which mentions that 'used_targets will become unavailable in future passes. This limits some opportunities for multiple source nodes to share a destination'. As per this comment, it was intended to share a node as demotion targets with some limits but the code limits not some but all such opportunities as no common node can be demotion targets for multiple source node as per current code. > mm: demotion: support to share demotion targets among sources > > Best Regards, > Huang, Ying > > [snip] > > >