Re: [linux-next:master 5085/5845] fs/userfaultfd.c:337:13: error: implicit declaration of function 'pte_none_mostly'

[Peter Xu <peterx@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]

On Sun, Apr 24, 2022 at 03:23:23AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   e7d6987e09a328d4a949701db40ef63fbb970670
> commit: 70a8da53f7cb7368776f9d2790ecbb4f8bc53ba5 [5085/5845] mm: teach core mm about pte markers
> config: x86_64-randconfig-a002-20210928 (https://download.01.org/0day-ci/archive/20220424/202204240320.TGDuGcsL-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=70a8da53f7cb7368776f9d2790ecbb4f8bc53ba5
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 70a8da53f7cb7368776f9d2790ecbb4f8bc53ba5
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> Note: the linux-next/master HEAD e7d6987e09a328d4a949701db40ef63fbb970670 builds fine.
>       It may have been fixed somewhere.
> 
> All errors (new ones prefixed by >>):
> 
>    fs/userfaultfd.c: In function 'userfaultfd_must_wait':
> >> fs/userfaultfd.c:337:13: error: implicit declaration of function 'pte_none_mostly' [-Werror=implicit-function-declaration]
>      337 |         if (pte_none_mostly(*pte))
>          |             ^~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors

Ah, userfaultfd.c may need explicit inclusion for swapops.h now..  Expected
fix attached to be squashed into "mm: Teach core mm about pte markers", I think.

Thanks,

-- 
Peter Xu

[-- Attachment #2: 0001-fixup-mm-Teach-core-mm-about-pte-markers.patch --]
[-- Type: text/plain, Size: 667 bytes --]

From 009572e59f7d72c5085676b0506f0b269f9ef334 Mon Sep 17 00:00:00 2001
From: Peter Xu <peterx@redhat.com>
Date: Sat, 23 Apr 2022 16:39:15 -0400
Subject: [PATCH] fixup! mm: Teach core mm about pte markers
Content-type: text/plain

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 fs/userfaultfd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
index fb45522a2b44..e943370107d0 100644
--- a/fs/userfaultfd.c
+++ b/fs/userfaultfd.c
@@ -29,6 +29,7 @@
 #include <linux/ioctl.h>
 #include <linux/security.h>
 #include <linux/hugetlb.h>
+#include <linux/swapops.h>
 
 int sysctl_unprivileged_userfaultfd __read_mostly;
 
-- 
2.32.0