From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31134C433EF for ; Fri, 22 Apr 2022 23:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6953A6B0073; Fri, 22 Apr 2022 19:04:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 643AC6B0074; Fri, 22 Apr 2022 19:04:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50C456B0075; Fri, 22 Apr 2022 19:04:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 3EBE56B0073 for ; Fri, 22 Apr 2022 19:04:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 04C9425515 for ; Fri, 22 Apr 2022 23:04:23 +0000 (UTC) X-FDA: 79386045648.09.EE4A187 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf20.hostedemail.com (Postfix) with ESMTP id D80051C002E for ; Fri, 22 Apr 2022 23:04:21 +0000 (UTC) Date: Fri, 22 Apr 2022 16:04:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1650668661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eyRc0yPN+29xdi/4+xeUBzYJPfwPORZ6hJjRKnqdiww=; b=uaqc1QkUHZNZt4aC2yiX1HThiAVJiYL+EOD4N27jmScBUS7pN79qWwsjm7s7NdNzokxpOp Od7DFH3byiUuMHSjm66Ms8dBsJG4NwuLfkq45/FYeU1Lcj8x9CQ6q4UtjsfeT/Y6WMHc2A 8HrFZRLJ9OXxSssElPnBVc6mBdCOPgQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: David Vernet Cc: akpm@linux-foundation.org, tj@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, kernel-team@fb.com Subject: Re: [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests Message-ID: References: <20220422155728.3055914-1-void@manifault.com> <20220422155728.3055914-2-void@manifault.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422155728.3055914-2-void@manifault.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D80051C002E X-Stat-Signature: tt7tqe4pkcb1skbmexbjyadwhe95zckp Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uaqc1QkU; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspam-User: X-HE-Tag: 1650668661-429066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 08:57:25AM -0700, David Vernet wrote: > In test_memcg_min() and test_memcg_low(), there is an array of four sibling > cgroups. All but one of these sibling groups does a 50MB allocation, and > the group that does no allocation is the third of four in the array. This > is not a problem per se, but makes it a bit tricky to do some assertions in > test_memcg_low(), as we want to make assertions on the siblings based on > whether or not they performed allocations. Having a static index before > which all groups have performed an allocation makes this cleaner. > > This patch therefore reorders the sibling groups so that the group that > performs no allocations is the last in the array. It makes the comment explaining the test just above the test_memcg_min() function obsolete. Please, fix it too. Thanks!