From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17700C433EF for ; Fri, 22 Apr 2022 18:03:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EA9C6B0073; Fri, 22 Apr 2022 14:03:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 772176B0074; Fri, 22 Apr 2022 14:03:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613FF6B0075; Fri, 22 Apr 2022 14:03:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 508DD6B0073 for ; Fri, 22 Apr 2022 14:03:09 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 014B72520D for ; Fri, 22 Apr 2022 18:03:08 +0000 (UTC) X-FDA: 79385286498.17.938B1D2 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf09.hostedemail.com (Postfix) with ESMTP id 9E0E7140028 for ; Fri, 22 Apr 2022 18:03:06 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8413EB83215; Fri, 22 Apr 2022 18:03:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F166FC385A0; Fri, 22 Apr 2022 18:03:01 +0000 (UTC) Date: Fri, 22 Apr 2022 19:02:58 +0100 From: Catalin Marinas To: Peter Collingbourne Cc: Andrey Konovalov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Linux ARM , Linux Memory Management List , Linux Kernel Mailing List , vbabka@suse.cz, penberg@kernel.org, roman.gushchin@linux.dev, iamjoonsoo.kim@lge.com, rientjes@google.com, Herbert Xu , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev , Eric Biederman , Kees Cook Subject: Re: [PATCH v2] mm: make minimum slab alignment a runtime property Message-ID: References: <20220421211549.3884453-1-pcc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220421211549.3884453-1-pcc@google.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9E0E7140028 X-Stat-Signature: 3aibufhg3sje8wgwrgt3gnx7ofbt3sgp Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspam-User: X-HE-Tag: 1650650586-296680 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 02:15:48PM -0700, Peter Collingbourne wrote: > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 373b3ef99f4e..80e517593372 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -201,21 +201,33 @@ void kmem_dump_obj(void *object); > #endif > > /* > - * Setting ARCH_SLAB_MINALIGN in arch headers allows a different alignment. > + * Setting ARCH_SLAB_MIN_MINALIGN in arch headers allows a different alignment. > * Intended for arches that get misalignment faults even for 64 bit integer > * aligned buffers. > */ > -#ifndef ARCH_SLAB_MINALIGN > -#define ARCH_SLAB_MINALIGN __alignof__(unsigned long long) > +#ifndef ARCH_SLAB_MIN_MINALIGN > +#define ARCH_SLAB_MIN_MINALIGN __alignof__(unsigned long long) > +#endif Sorry, only a drive-by comment, I'll look at the arm64 parts next week. I've seen it mentioned in the first version, what's the point of MIN_MIN and not just MIN? -- Catalin