From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F67C4332F for ; Fri, 22 Apr 2022 15:00:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C10526B0085; Fri, 22 Apr 2022 11:00:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC0166B0087; Fri, 22 Apr 2022 11:00:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A88A36B0088; Fri, 22 Apr 2022 11:00:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 98BE06B0085 for ; Fri, 22 Apr 2022 11:00:48 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D2B1F75E for ; Fri, 22 Apr 2022 15:00:47 +0000 (UTC) X-FDA: 79384826934.29.D85CEA3 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf01.hostedemail.com (Postfix) with ESMTP id 916F64003E for ; Fri, 22 Apr 2022 15:00:44 +0000 (UTC) Date: Fri, 22 Apr 2022 08:00:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1650639644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d3IirLrwzfP+t0cf/Qt/pjPqRe913cYQABamRgMemA8=; b=Lm54JO89yEThLSIOPkqiO6LOVwh/7ZwT7BCwz0zLcI/aXxl9HFRy2wt5mfdfSbbE+e+BYB bQyb0q49de7JTreNY6cN9UX4H5WWDQWzNEHLbyyXbGLILRdK/dSOz1lUkEN4UbqazIhnP8 3DvXNVVjpOLYzc3+lxM/e73OuXDStK4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Muchun Song Cc: Waiman Long , Johannes Weiner , Michal Hocko , Shakeel Butt , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Yang Shi , Vlastimil Babka Subject: Re: [PATCH] mm/memcg: Free percpu stats memory of dying memcg's Message-ID: References: <20220421145845.1044652-1-longman@redhat.com> <112a4d7f-bc53-6e59-7bb8-6fecb65d045d@redhat.com> <58c41f14-356e-88dd-54aa-dc6873bf80ff@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Stat-Signature: 7iy6p36jwq56e9d3gmy7d8b1h8hmkzxm X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Lm54JO89; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 916F64003E X-HE-Tag: 1650639644-732241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 06:27:22PM +0800, Muchun Song wrote: > On Thu, Apr 21, 2022 at 07:59:00PM -0700, Roman Gushchin wrote: > > On Thu, Apr 21, 2022 at 02:46:00PM -0400, Waiman Long wrote: > > > On 4/21/22 13:59, Roman Gushchin wrote: > > > > On Thu, Apr 21, 2022 at 01:28:20PM -0400, Waiman Long wrote: > > > > > On 4/21/22 12:33, Roman Gushchin wrote: > > > > > > On Thu, Apr 21, 2022 at 10:58:45AM -0400, Waiman Long wrote: > > > > > > > For systems with large number of CPUs, the majority of the memory > > > > > > > consumed by the mem_cgroup structure is actually the percpu stats > > > > > > > memory. When a large number of memory cgroups are continuously created > > > > > > > and destroyed (like in a container host), it is possible that more > > > > > > > and more mem_cgroup structures remained in the dying state holding up > > > > > > > increasing amount of percpu memory. > > > > > > > > > > > > > > We can't free up the memory of the dying mem_cgroup structure due to > > > > > > > active references in some other places. However, the percpu stats memory > > > > > > > allocated to that mem_cgroup is a different story. > > > > > > > > > > > > > > This patch adds a new percpu_stats_disabled variable to keep track of > > > > > > > the state of the percpu stats memory. If the variable is set, percpu > > > > > > > stats update will be disabled for that particular memcg. All the stats > > > > > > > update will be forward to its parent instead. Reading of the its percpu > > > > > > > stats will return 0. > > > > > > > > > > > > > > The flushing and freeing of the percpu stats memory is a multi-step > > > > > > > process. The percpu_stats_disabled variable is set when the memcg is > > > > > > > being set to offline state. After a grace period with the help of RCU, > > > > > > > the percpu stats data are flushed and then freed. > > > > > > > > > > > > > > This will greatly reduce the amount of memory held up by dying memory > > > > > > > cgroups. > > > > > > > > > > > > > > By running a simple management tool for container 2000 times per test > > > > > > > run, below are the results of increases of percpu memory (as reported > > > > > > > in /proc/meminfo) and nr_dying_descendants in root's cgroup.stat. > > > > > > Hi Waiman! > > > > > > > > > > > > I've been proposing the same idea some time ago: > > > > > > https://lore.kernel.org/all/20190312223404.28665-7-guro@fb.com/T/ . > > > > > > > > > > > > However I dropped it with the thinking that with many other fixes > > > > > > preventing the accumulation of the dying cgroups it's not worth the added > > > > > > complexity and a potential cpu overhead. > > > > > > > > > > > > I think it ultimately comes to the number of dying cgroups. If it's low, > > > > > > memory savings are not worth the cpu overhead. If it's high, they are. > > > > > > I hope long-term to drive it down significantly (with lru-pages reparenting > > > > > > being the first major milestone), but it might take a while. > > > > > > > > > > > > I don't have a strong opinion either way, just want to dump my thoughts > > > > > > on this. > > > > > I have quite a number of customer cases complaining about increasing percpu > > > > > memory usages. The number of dying memcg's can go to tens of thousands. From > > > > > my own investigation, I believe that those dying memcg's are not freed > > > > > because they are pinned down by references in the page structure. I am aware > > > > > that we support the use of objcg in the page structure which will allow easy > > > > > reparenting, but most pages don't do that and it is not easy to do this > > > > > conversion and it may take quite a while to do that. > > > > The big question is whether there is a memory pressure on those systems. > > > > If yes, and the number of dying cgroups is growing, it's worth investigating. > > > > It might be due to the sharing of pagecache pages and this will be ultimately > > > > fixed with implementing of the pagecache reparenting. But it also might be due > > > > to other bugs, which are fixable, so it would be great to understand. > > > > > > > > > Pagecache reparenting will probably fix the problem that I have seen. Is > > > someone working on this? > > > > Some time ago Muchun posted patches based on the reusing of the obj_cgroup API. > > > > Yep. It is here: > > https://lore.kernel.org/all/20220216115132.52602-1-songmuchun@bytedance.com/. > > > I'm not strictly against this approach, but in my opinion it's not the best. > > I suggested to use lru vectors as an intermediate objects. In theory, it might > > I remember this. > > > allow to avoid bumping reference counters for all charged pages at all: live > > cgroups will be protected by being live, dying cgroups will only need > > a temporarily protection while lru vectors and associated pages are reparenting. > > > > There are pros and cons: > > + cgroup reference counting becomes simpler and more debuggable > > + potential perf wins from fewer operations with live cgroups css refcounters > > = I hope to see code simplifications (but not guaranteed) > > - deleting cgroups becomes more expensive, but the cost can be spread to > > asynchronous workers > > > > Idk if Muchun tried to implement it. If not, I might try myself. > > > > Yep. I have implemented a initial version recently. I'll do some stability tests > and send it out ASAP. Great! Looking forward to see it! And thank you for working on it!