From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D915C433F5 for ; Fri, 22 Apr 2022 12:32:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B59F66B0074; Fri, 22 Apr 2022 08:32:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE2186B0075; Fri, 22 Apr 2022 08:32:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95B6C6B0078; Fri, 22 Apr 2022 08:32:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 820AF6B0074 for ; Fri, 22 Apr 2022 08:32:47 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 585032447D for ; Fri, 22 Apr 2022 12:32:47 +0000 (UTC) X-FDA: 79384453974.16.00B12F9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id 33CC2A0022 for ; Fri, 22 Apr 2022 12:32:44 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 992DD1F37B; Fri, 22 Apr 2022 12:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1650630765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+IobmFBFjT5qqNpP/BKZ8Ms1ddIzrsBOvPdgsM35n4=; b=Bs5UUzIHvMG4EGaAaZ/SUd5vBPbp564K/grLuYXO0vTHtByfy1jVHAfyvv26c0phaCuW+z A0FA0MJ/PGgo7P5FuofrDqw9gPRjgKIuPKOPE9XDkfm7/ZfJf3HmA/wr2z1SoL5+41ogpK Q71YFO/p2o2Pxic6PdWz8o3OW5+dTxM= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 6616B2C141; Fri, 22 Apr 2022 12:32:45 +0000 (UTC) Date: Fri, 22 Apr 2022 14:32:44 +0200 From: Michal Hocko To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hch@lst.de, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, roman.gushchin@linux.dev Subject: Re: [PATCH v2 7/8] mm: Move lib/show_mem.c to mm/ Message-ID: References: <20220421234837.3629927-1-kent.overstreet@gmail.com> <20220421234837.3629927-13-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220421234837.3629927-13-kent.overstreet@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: 33CC2A0022 X-Stat-Signature: 844gdycmydd9kgba48kwigubrgjg6i59 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Bs5UUzIH; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam01 X-HE-Tag: 1650630764-849889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 21-04-22 19:48:36, Kent Overstreet wrote: > show_mem.c is really mm specific, and the next patch in the series is > going to require mm/slab.h, so let's move it before doing more work on > it. > > Signed-off-by: Kent Overstreet No real objections on this. I do agree that this is an mm specific thing. It depends on other things in mm/page_alloc.c so I wouldn't mind those living close together. Acked-by: Michal Hocko > --- > lib/Makefile | 2 +- > mm/Makefile | 2 +- > {lib => mm}/show_mem.c | 0 > 3 files changed, 2 insertions(+), 2 deletions(-) > rename {lib => mm}/show_mem.c (100%) > > diff --git a/lib/Makefile b/lib/Makefile > index 31a3904eda..c5041d33d0 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -30,7 +30,7 @@ endif > lib-y := ctype.o string.o vsprintf.o cmdline.o \ > rbtree.o radix-tree.o timerqueue.o xarray.o \ > idr.o extable.o sha1.o irq_regs.o argv_split.o \ > - flex_proportions.o ratelimit.o show_mem.o \ > + flex_proportions.o ratelimit.o \ > is_single_threaded.o plist.o decompress.o kobject_uevent.o \ > earlycpio.o seq_buf.o siphash.o dec_and_lock.o \ > nmi_backtrace.o nodemask.o win_minmax.o memcat_p.o \ > diff --git a/mm/Makefile b/mm/Makefile > index 70d4309c9c..97c0be12f3 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -54,7 +54,7 @@ obj-y := filemap.o mempool.o oom_kill.o fadvise.o \ > mm_init.o percpu.o slab_common.o \ > compaction.o vmacache.o \ > interval_tree.o list_lru.o workingset.o \ > - debug.o gup.o mmap_lock.o $(mmu-y) > + debug.o gup.o mmap_lock.o show_mem.o $(mmu-y) > > # Give 'page_alloc' its own module-parameter namespace > page-alloc-y := page_alloc.o > diff --git a/lib/show_mem.c b/mm/show_mem.c > similarity index 100% > rename from lib/show_mem.c > rename to mm/show_mem.c > -- > 2.35.2 -- Michal Hocko SUSE Labs