From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1285C433F5 for ; Fri, 22 Apr 2022 14:42:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 212296B007D; Fri, 22 Apr 2022 10:42:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19B2E6B007E; Fri, 22 Apr 2022 10:42:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03BB96B0080; Fri, 22 Apr 2022 10:42:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id E2CDA6B007D for ; Fri, 22 Apr 2022 10:42:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A2F0E24786 for ; Fri, 22 Apr 2022 14:42:36 +0000 (UTC) X-FDA: 79384781112.16.003A419 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 6D7EDC000F for ; Fri, 22 Apr 2022 14:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JfaFBap5XOtEB+YkkJ9E9pvw6jjkwyxBWuZ63OV8jOo=; b=2iW4xAij7Xo+8jKTLoxPTikuIu Fi62Db6A46bHFst2qLDayoFWOb6RX6ajDK/tjDgbw4Pp5AR+9Y7Nc+WmtKOA5T3+cA6Hd1Ba/7NMl /H7JeZ4vNiMnbDct96DTc0XhWrFzeGMii1/9riBIc9DQAeXnDvco+HHPcdDJSXDvg/XPKZtB/77na zmba1NEbnS/W29AXrGd4wjDpw0S6Hh31RRpAHGtnkzgO4KYM3/9N1iN6BLGyxf86UL3iTp9S9EfJ2 GynSoMhj1cmlB3tfGWVWw9qnFEUdF2Z0z7EwCyuhCfiJia20VFlM4CvE0TVx8EZ7CI0Rqw+PLuWMl BrrXqijA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhuUS-000s6V-32; Fri, 22 Apr 2022 14:42:32 +0000 Date: Fri, 22 Apr 2022 07:42:32 -0700 From: Luis Chamberlain To: Song Liu , Linus Torvalds Cc: bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, akpm@linux-foundation.org, rick.p.edgecombe@intel.com, hch@infradead.org, imbrenda@linux.ibm.com Subject: Re: [PATCH bpf 0/4] bpf_prog_pack and vmalloc-on-huge-page fixes Message-ID: References: <20220422051813.1989257-1-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422051813.1989257-1-song@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6D7EDC000F X-Stat-Signature: dpge5e8z6j1w6mytf8dtjan6r9w7rg4a Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2iW4xAij; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf28.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org X-HE-Tag: 1650638552-260747 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 10:18:09PM -0700, Song Liu wrote: > NOTE: This set is based on Linus' master branch (d569e86915b7), not > bpf/master. > > There are various discussion about these changes, check out [1] [2]. > I guess we can use this thread to discuss which patches should go in 5.18. > AFAICT, 1/4 need to with 5.18; Since huge pages are effectively disabled on v5.18 I can't see why. > 2/4 seems safe to go as well; My impression on the discussion was that huge pages design was broken and evidence for this came up after x86 finally enabled *a small* portion use case of it. This revealed how broken huge pages were not just for x86 but for other architectures. And so I can't see why we'd enable for v5.18 huge pages for the large system hash. > 3/4 and 4/4 > may still need more work/discussion. Happy to review these but if huge pages are disabled I don't see the point in a module_alloc_huge() yet. Luis > > Thanks! > > [1] https://lore.kernel.org/linux-mm/20220415164413.2727220-1-song@kernel.org/ > [2] https://lore.kernel.org/linux-mm/20220421072212.608884-1-song@kernel.org/ > > Song Liu (4): > bpf: invalidate unused part of bpf_prog_pack > page_alloc: use vmalloc_huge for large system hash > module: introduce module_alloc_huge > bpf: use module_alloc_huge for bpf_prog_pack > > arch/x86/kernel/module.c | 21 +++++++++++++++++++++ > arch/x86/net/bpf_jit_comp.c | 22 ++++++++++++++++++++++ > include/linux/bpf.h | 2 ++ > include/linux/moduleloader.h | 5 +++++ > kernel/bpf/core.c | 28 +++++++++++++++++++++------- > kernel/module.c | 8 ++++++++ > mm/page_alloc.c | 2 +- > 7 files changed, 80 insertions(+), 8 deletions(-) > > -- > 2.30.2