From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89158C433EF for ; Fri, 22 Apr 2022 06:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08AEF6B0072; Fri, 22 Apr 2022 02:06:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 012CD6B0073; Fri, 22 Apr 2022 02:06:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCDFE6B0074; Fri, 22 Apr 2022 02:06:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id C890F6B0072 for ; Fri, 22 Apr 2022 02:06:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 930A880929 for ; Fri, 22 Apr 2022 06:06:48 +0000 (UTC) X-FDA: 79383481296.25.FA26E62 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf21.hostedemail.com (Postfix) with ESMTP id 844D41C0024 for ; Fri, 22 Apr 2022 06:06:46 +0000 (UTC) Received: by mail-qt1-f175.google.com with SMTP id d9so4861991qty.12 for ; Thu, 21 Apr 2022 23:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nlwTOZ4YA/xOCHbD8FxUxJ0ALmhsKy74mVaGByAE/8I=; b=ioNzbL2gm0qTBiumcIbqb1lW02l7rCuVIZkqQHRgPSCHyQ/iSFaBnqgC6hI6k9OMaO ySyyLvesbK5A1AMxTg1+fGrgu41/+Q9bl340D8UifBxdRbgQkdDdwA7p3KSi+yZ8U4YT nItp/MoET7VAA/G5Gtrd1jxeCOqLEweeplauXFCUKCT7voyCZtIpeli9W38SnbD8T0P8 Y1EQRAgrpSdsXUodnvkmaFiUzfeDmil8vEemhX0uowrKcUBQqa2FfIeuK7b0X10HHOvR PAbKrmBTK4rdhbTXM+rd0HpMige7E/RAMaA69UwRSxwnOW/0uTMdflGU/ftaz0rGuc/n d4Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nlwTOZ4YA/xOCHbD8FxUxJ0ALmhsKy74mVaGByAE/8I=; b=Mkh1Hw+N3du6PRZo/VczkuUp2C2rU/v7l6NJVPb5qULh3XPFZZHCqGUCn/tm1Hh2Ow ajLmzN9TRnChpOVbPN4L24jdE+SIi8eBvv7UulIIFmUQh87Ci7DMaj8lZhqJlIcOpiWE Gu8PfYcGpe79iQTvtg4dh52ckxcizECXW2rkBgJJb32/amBMNzp9Ytr9k0S9uyL7MT8a 3+to14o+fa72I43mQytjAhnwKEAv9zz5IaXtpCq6h2GTGW55m2NavtIcMH/r9gDo6cO0 EqZKpU1CHtOsXRNi9ZJkZtcusCEt8EDS3kz96Ipoh0O2QhexewYPSpdWEjdG2cHvzMD/ TnSg== X-Gm-Message-State: AOAM530bW98sXZp+B37AeIujjGLk1FpZWSy2VrciBA5sm96lnTwkJHhI WALz6DJzBm2fL+eyDK6Zig== X-Google-Smtp-Source: ABdhPJxBx0pVVOt3R/hgC5qhlwNRAyGX6fTiF6NzSOaDtaiiJfoWmXioOxpYYXOgp3DOPsKkZrO9wA== X-Received: by 2002:ac8:5a81:0:b0:2f1:f20d:173a with SMTP id c1-20020ac85a81000000b002f1f20d173amr2073685qtc.686.1650607607411; Thu, 21 Apr 2022 23:06:47 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id bk18-20020a05620a1a1200b00680c72b7bf4sm564935qkb.93.2022.04.21.23.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 23:06:46 -0700 (PDT) Date: Fri, 22 Apr 2022 02:06:44 -0400 From: Kent Overstreet To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, roman.gushchin@linux.dev, rostedt@goodmis.org Subject: Re: [PATCH v2 1/8] lib/printbuf: New data structure for heap-allocated strings Message-ID: References: <20220421234837.3629927-1-kent.overstreet@gmail.com> <20220421234837.3629927-7-kent.overstreet@gmail.com> <20220422042017.GA9946@lst.de> <20220422052208.GA10745@lst.de> <20220422055214.GA11281@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422055214.GA11281@lst.de> Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ioNzbL2g; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 844D41C0024 X-Stat-Signature: kq5qc9rp4fkier5jzbbqi4raekjwye77 X-HE-Tag: 1650607606-333588 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 07:52:14AM +0200, Christoph Hellwig wrote: > On Fri, Apr 22, 2022 at 01:40:15AM -0400, Kent Overstreet wrote: > > Wasn't just bcachefs, it affected bcache too, as Coly also reported. > > Well, I've not seen a good bug report for that, but I'd gladly look at it. Thanks. It's been awhile but I'll see if I can dig up the original bug report tomorrow. > > And I wrote > > that code originally (and the whole fucking modern bvec iter infrastracture, > > mind you) so please don't lecture me on making assumptions on block layer > > helpers. > > Well, most of what we have is really from Ming. Because your original > idea was awesome, but the code didn't really fit. Then again I'm not > sure why this even matters. Didn't fit how? And Ming extended it to multipage bvecs based on my proposal. > I'm also relly not sure why you are getting so personal. Put yourself my shoes, I've honestly found you to be hardheaded and exceedingly difficult to work with for a very long time. But I'll bite my tongue for now, because if you'll start listening to bug reports that will go a long way towards easing things, and we've got LSF coming up so maybe we can hash things out over beers. > > Now yes, I _could_ do a wholesale conversion of seq_buf to printbuf and delete > > that code, but doing that job right, to be confident that I'm not introducing > > bugs, is going to take more time than I really want to invest right now. I > > really don't like to play fast and loose with that stuff. > > Even of that I'd rather see a very good reason first. seq_bufs have been > in the kernel for a while and seem to work fine. If you think there are > shortcomings please try to improve it, not replace or duplicate it. > Sometimes there might be a good reason to replace exiting code, but it > rather have to be a very good reason. When the new version is semantically different from the old version it makes it a lot easier to deal with the merge conflicts later when forward/backporting stuff by giving the new version a new name. Anyways, I'll have a chat with Steven Rostedt about it since I believe he wrote the original code.