From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4ECAC433F5 for ; Fri, 22 Apr 2022 05:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AA816B0072; Fri, 22 Apr 2022 01:14:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3593F6B0073; Fri, 22 Apr 2022 01:14:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 220E86B0074; Fri, 22 Apr 2022 01:14:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 12BEB6B0072 for ; Fri, 22 Apr 2022 01:14:52 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CBB51209C3 for ; Fri, 22 Apr 2022 05:14:51 +0000 (UTC) X-FDA: 79383350382.20.795DDA0 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf21.hostedemail.com (Postfix) with ESMTP id C1FEA1C0006 for ; Fri, 22 Apr 2022 05:14:49 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id a186so5111173qkc.10 for ; Thu, 21 Apr 2022 22:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UzSUlOF8KDoR9NJ195sba6wlXvE2bZq/DNakp665B3U=; b=Q3BsiOHfa13lTsLovJcciqc6FjUgOUDC6KinPy12Ag9ltwCqDBD+ZtMyPz7wLhlV/8 ZSiuFocRSyixr8LtHibcNXL12OMlM6+C7cIB8IHE+8zbnjxJYWSYK7aOVbca29PvxhUg OALWJgRDhEdhGCUWMmm7K04X+UpW3SqSp2i6D1ZSvcvzxOKadXybwn/M0YRS7gm03S9e GsZyBjkC9UYraiYlo71nunqLJ7Fi4trfrovdMPt2uVbYTmFjfmQE23K0EAzmBRGQlebk 1NeAVrDNVx3PUN96KHTeyvB7T+SrOaE/tL0dYyXuVNmKxy1CN5TOSHe7lICCEHthNk4u SW4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UzSUlOF8KDoR9NJ195sba6wlXvE2bZq/DNakp665B3U=; b=umDXuLnyHvYvRmMCQbkxy/P7HB6yDIW0ydFKJP79q4m+uvWm8K392FX6lSHIe3jLVM 8OaviKADXGTqDZprhflqGZKV1UPCQkWwmVCzJxmsC3N3QaFDMS8/Zv/gFC+ZO+EI//iy dXzAHKrFhVxLl3aus7fm0biQWoxNv8O501aIwckJ2jAruUuRDQyS5Qlki4pXklUh+h7R odGSe6FJLNOAGtf1wFeaq4qxbRIJ3lRfrzwE6c6Bi/yG30M4E3qylPEnvWShD+/oVTwW xIouwaizYdUiyDG0ZQlkQGL8S3LqMT1kEeTuBbbjxgRyVk2tEAtwW01AAXDrZikCeN0h /Luw== X-Gm-Message-State: AOAM532q85D/49pGxsA2t0HuyopAQvaAsqv/E1HGKGJvzQeTRvV8xe+Z aWD/wOOTkEySF7QHn7ZSqA== X-Google-Smtp-Source: ABdhPJyEkvdj189+G4fcRUz/WVIjCgUY6uQFAlInHCF4wn3U7HrpUYbtDEIKZMQg+DyB/6RApN2zdA== X-Received: by 2002:a05:620a:13bb:b0:69e:8b7c:1037 with SMTP id m27-20020a05620a13bb00b0069e8b7c1037mr1659008qki.703.1650604490631; Thu, 21 Apr 2022 22:14:50 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id u11-20020a05622a14cb00b002e1fd9dce3dsm690671qtx.60.2022.04.21.22.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 22:14:50 -0700 (PDT) Date: Fri, 22 Apr 2022 01:14:48 -0400 From: Kent Overstreet To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, roman.gushchin@linux.dev, rostedt@goodmis.org Subject: Re: [PATCH v2 1/8] lib/printbuf: New data structure for heap-allocated strings Message-ID: References: <20220421234837.3629927-1-kent.overstreet@gmail.com> <20220421234837.3629927-7-kent.overstreet@gmail.com> <20220422042017.GA9946@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422042017.GA9946@lst.de> X-Stat-Signature: azc38fpdjerwi7md7smuzyaj5m4ckwqr X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Q3BsiOHf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C1FEA1C0006 X-HE-Tag: 1650604489-384707 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 06:20:17AM +0200, Christoph Hellwig wrote: > I still see absolutel no reason to bloat the kernel with a duplicate > of the existing seq_buf functionality. Please use that and improve it > where needed for your use case. Christoph, you have no problem making more work for me but I can't even get you to look at the bugs you introuduce in your refactorings that I report to you. Still waiting on you to look at oops you introduced in bio_copy_data_iter...