From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6078BC433EF for ; Thu, 21 Apr 2022 22:22:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B68466B0072; Thu, 21 Apr 2022 18:22:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF7E6B0073; Thu, 21 Apr 2022 18:22:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96ADA6B0074; Thu, 21 Apr 2022 18:22:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 8396A6B0072 for ; Thu, 21 Apr 2022 18:22:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4BF6327AFA for ; Thu, 21 Apr 2022 22:22:39 +0000 (UTC) X-FDA: 79382311638.03.8901A96 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf22.hostedemail.com (Postfix) with ESMTP id 7A18FC0002 for ; Thu, 21 Apr 2022 22:22:38 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id n18so6791004plg.5 for ; Thu, 21 Apr 2022 15:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y6WfdHbJCYQzab5SHoARzKzrfz2r1T0YKiP1hNGHigk=; b=ZO4eaJJc1D/7LWDis399vvRSyw5MBy95K81Welr1tTB6Wq6BW/lnNe2/GwfAzvcz6I U8IY9rPktTgn8KKX28BEbFqA2GiE6eHzQ9XWVWv7mNUeVqphiyNt+GJUxnsztz8BpCPV pzc//pxX7LAS0hEczz1kc/IY7mbLuU43a71tTY8CiViZu7u09/nrRr3pBLVXcrulUICa cIwUXxKbhjYv/yFzkWpLASqQfnmniPnwYmJUAhxZLyJJzhA6nFTI0HbFrYdvYl8E/Nh6 JEmekiIqu9b3PmiaUaSqwKeUHq7TokiOmj5/CZqHGBre+241ESZz3lxcjwDeUbJwsIJn WIuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=y6WfdHbJCYQzab5SHoARzKzrfz2r1T0YKiP1hNGHigk=; b=dGQhJ8+mdMj3hYZJ5frLbsGs+H75rHwmawV2ZkNETdSHvJ0/8NVGSyu8Ae1W9gnb7/ q0O8AI0gB6nc+pPJdf7oAIHhSL4Omuvnd2EmUB2v2sAnQ/vs68RDg6MP9231I4kpyHgh Jwke0y/VQbNInt/oCEC7bV08AM1pO1UVYMiMqjyqmg55iUKfRQ6SBiVXmkpblT7rieuV cnlTasWMGaAfGxtBDN6ia4n1G9mgoWU5bEtrWo0kRzF33j9iIDbzTAIjGNSovKS04YI+ f+SXk2hPjnfWQunL56RYhithF1UBZObQQDhSbnd9XUGXeGDZVrybzhdacTRuL7sXbehh zkCg== X-Gm-Message-State: AOAM531FGJVJgKyNKtRihaR1oredY0ZhzoLdRTWzfFaOypLz3k57+97N PZ4pl+0LJEHfyeMjw8goHc8= X-Google-Smtp-Source: ABdhPJwcH1qQPnuyd1zNvqMCwJDjmVEJquDucXk6REkrlVLU+xbI/lFSLpOuM9G+0hwzFZ+EI7nrGg== X-Received: by 2002:a17:902:9307:b0:154:78ba:ed40 with SMTP id bc7-20020a170902930700b0015478baed40mr1609624plb.92.1650579757619; Thu, 21 Apr 2022 15:22:37 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:15fa]) by smtp.gmail.com with ESMTPSA id 129-20020a621687000000b0050579d13b1csm119388pfw.137.2022.04.21.15.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 15:22:37 -0700 (PDT) Date: Thu, 21 Apr 2022 12:22:35 -1000 From: Tejun Heo To: Feng Tang Cc: Zefan Li , Johannes Weiner , Andrew Morton , Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, Dave Hansen , ying.huang@intel.com, Waiman Long Subject: Re: [RFC PATCH] cgroup/cpuset: fix a memory binding failure for cgroup v2 Message-ID: References: <20220419020958.40419-1-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419020958.40419-1-feng.tang@intel.com> Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZO4eaJJc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf22.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=htejun@gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7A18FC0002 X-Stat-Signature: 5w4kyo6k443cdqa4mgcpnekey9tfhb4i X-HE-Tag: 1650579758-704801 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: cc'ing Waiman and copying the whole body. Waiman, can you please take a look? Thanks. On Tue, Apr 19, 2022 at 10:09:58AM +0800, Feng Tang wrote: > We got report that setting cpuset.mems failed when the nodemask > contains a newly onlined memory node (not enumerated during boot) > for cgroup v2, while the binding succeeded for cgroup v1. > > The root cause is, for cgroup v2, when a new memory node is onlined, > top_cpuset's 'mem_allowed' is not updated with the new nodemask of > memory nodes, and the following setting memory nodemask will fail, > if the nodemask contains a new node. > > Fix it by updating top_cpuset.mems_allowed right after the > new memory node is onlined, just like v1. > > Signed-off-by: Feng Tang > --- > Very likely I missed some details here, but it looks strange that > the top_cpuset.mem_allowed is not updatd even after we onlined > several memory nodes after boot. > > kernel/cgroup/cpuset.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 9390bfd9f1cd..b97caaf16374 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3314,8 +3314,7 @@ static void cpuset_hotplug_workfn(struct work_struct *work) > /* synchronize mems_allowed to N_MEMORY */ > if (mems_updated) { > spin_lock_irq(&callback_lock); > - if (!on_dfl) > - top_cpuset.mems_allowed = new_mems; > + top_cpuset.mems_allowed = new_mems; > top_cpuset.effective_mems = new_mems; > spin_unlock_irq(&callback_lock); > update_tasks_nodemask(&top_cpuset); > -- > 2.27.0 > -- tejun