From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C85C4332F for ; Thu, 21 Apr 2022 21:44:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6400F6B0072; Thu, 21 Apr 2022 17:44:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F46A6B0073; Thu, 21 Apr 2022 17:44:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DD046B0074; Thu, 21 Apr 2022 17:44:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 3FD756B0072 for ; Thu, 21 Apr 2022 17:44:47 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 066C86199F for ; Thu, 21 Apr 2022 21:44:46 +0000 (UTC) X-FDA: 79382216214.10.87FB95F Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf17.hostedemail.com (Postfix) with ESMTP id 5E5534000F for ; Thu, 21 Apr 2022 21:44:43 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id t12so6617765pll.7 for ; Thu, 21 Apr 2022 14:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GIkmPRn6aXIFTLXMDEzU8Z7cPf9kdXdPCyaOczwE6x0=; b=Y+ot/N7E3NqtwNRkxxSQvG8RLexpxttLfKY4X2H753dGZgDytqswn3fJSKyb3cJFbH li+mL9j7bJx2hlPee+M4Olu2UZNUV2GxkQAjVde+z8e/75fQjDwi9Fnvqbrk3yHU/RBZ 9NE7UFSIwy6xkhNy7ODaqcifxQ58kzt+nyKjzpBJ2xVhIXHf8KY3VVOt4PiYl+cSzeKY Nu0bQZioVPXHgcvVihXVQDPHhnx9ZdX1+d0UPvh5V2OMKUv0qIIc9T9OoQcyq78QovKw z43U2HpqbNvSPKATYbDIhMdIrOfXUdMI4W5mQynu/1WEcGaLs4vVOgTTz5l8xUcx1a32 Vrtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=GIkmPRn6aXIFTLXMDEzU8Z7cPf9kdXdPCyaOczwE6x0=; b=ayrjM7v3BTXpsG+3Nn/ibscjAIDHj3xJst1epH+QnL4S8AN9kW3HNUUMp3u2V5m1CC 49hfdpA+6ZyWITx5mN2UL3p6i6RxwgXMRcewUCDWRIPAD6H9Zpj3s1DIffN2A9vVgSMK Hj4xxAzWvADqGQHyQYnz05ZeP9/h8IKtq+sX/XHqlGBatvNLjrfpbEKvpK1b2mclttG/ xVo3MgRPQEmR0bZEYRGgRMh5/XorubCxIGE6kDXsBLog5EWTOeYKEGPZwb69eKageSe7 wZnvFobOwNicSFJ00C/qPBbI2tXfxnkj+8IMTa9ORyqaIRd6ygmesBTFSHu7+l/wEK0J pEdg== X-Gm-Message-State: AOAM530prLE567eS0iTMENA6FeLLxQi+SekKrKHZwl6Mf1rD7uq9Vvw1 L0ZY7PVA640M41gjNBzTqG4= X-Google-Smtp-Source: ABdhPJxHcJDy80tcA6sx3LqqnfHByJ4eX9ilg9ZOtqESXPl+xJmI1z5M+822VXfcwS0QGTJePQ/7fw== X-Received: by 2002:a17:90a:6445:b0:1d6:a69e:406c with SMTP id y5-20020a17090a644500b001d6a69e406cmr4662624pjm.49.1650577485382; Thu, 21 Apr 2022 14:44:45 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:15fa]) by smtp.gmail.com with ESMTPSA id y4-20020a056a00190400b004fac0896e35sm80878pfi.42.2022.04.21.14.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 14:44:44 -0700 (PDT) Date: Thu, 21 Apr 2022 11:44:43 -1000 From: Tejun Heo To: Christoph Hellwig Cc: Jens Axboe , Paolo Valente , James Smart , Dick Kennedy , linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mm@kvack.org Subject: Re: make the blkcg and blkcg structures private Message-ID: References: <20220420042723.1010598-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220420042723.1010598-1-hch@lst.de> Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Y+ot/N7E"; spf=pass (imf17.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Stat-Signature: 7rjstizk4mo5fiqxhsrxgfoe38z5jri7 X-Rspamd-Queue-Id: 5E5534000F X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1650577483-27342 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000516, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Wed, Apr 20, 2022 at 06:27:08AM +0200, Christoph Hellwig wrote: > this series cleans up various lose end in the blk-cgroup code to make it > easier to follow in preparation of reworking the blkcg assignment for > bios. The biggest change is that most of is now > taken private into block/. The patches look all good to me and I'm not against making things more private but can you elaborate on the rationale a bit more? By and large, we have never been shy about putting things in the headers if there's *any* (perceived) gain to be made from doing so, or even just as a way to pick the locations for different things - type defs go on header and so on. Most of the inlines and [un]likely's that we have are rather silly with modern compilers with global optimizations, so it does make sense to get tidier, but if that's the rationale, mentioning that in the commit message, even briefly, would be great - ie. it should explain the benefits of adding these few accessors to keep the definition private. Thanks. -- tejun