From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69455C433EF for ; Thu, 21 Apr 2022 19:30:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDBEE6B0072; Thu, 21 Apr 2022 15:30:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D65D86B0073; Thu, 21 Apr 2022 15:30:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C05206B007D; Thu, 21 Apr 2022 15:30:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id B11AC6B0072 for ; Thu, 21 Apr 2022 15:30:27 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 75A8624228 for ; Thu, 21 Apr 2022 19:30:27 +0000 (UTC) X-FDA: 79381877694.05.5FE7441 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 11EC3C0031 for ; Thu, 21 Apr 2022 19:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7YCqoM+OLSScIKj5SFV1xnv7Lq3/KtSA68DSkvEprg=; b=Vhti+WEyr4COI6tQth8L0dFrJX L2Qc2PLVL/AHjkI6Hkl21Z4mjVTBJ2aYR2End8Zj5O14N7BfCgaZAabD6VddgKDMPH/1ZO+u3TXMi 6LQIjCON6T5lsOgfkDbuujm+HFjoMmXUBsCK6vaV8MneweQ+aTM7ZeGS8ws9OqUKIjg6p04U7IQ1v seX0zss2MD+NHWCaEAgm79Fplz6wztO9g3O6CesQRj0rD9T0+IJGN5GN0K4aIa1lMC2M3xV2pHvBz i1AilLwl4bs8ZEPTGXYhX2wfh0PXfS1OCi1xw4J9cy0dFBMW4/sSnqdwsOrvaIRpZJR2Pd7300ex5 kR3XchWg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhcVR-005O1O-On; Thu, 21 Apr 2022 19:30:21 +0000 Date: Thu, 21 Apr 2022 20:30:21 +0100 From: Matthew Wilcox To: Nico Pache Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , Arjan van de Ven , Ulrich Drepper Subject: Re: [RFC 2/3] futex: exit: Print a warning when futex_cleanup fails Message-ID: References: <20220421190533.1601879-1-npache@redhat.com> <20220421190533.1601879-3-npache@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220421190533.1601879-3-npache@redhat.com> Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Vhti+WEy; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 11EC3C0031 X-Stat-Signature: burn149ois1hmdx99cwqgoi1acwn66zo X-HE-Tag: 1650569423-650108 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 03:05:32PM -0400, Nico Pache wrote: > @@ -1007,13 +1013,15 @@ static inline void exit_pi_state_list(struct task_struct *curr) { } > static void futex_cleanup(struct task_struct *tsk) > { > if (unlikely(tsk->robust_list)) { > - exit_robust_list(tsk); > + if (!exit_robust_list(tsk)) > + pr_info("futex: exit_robust_list failed"); Doesn't this allow a malicious user process to spam the kernel logs with messages? There needs to be a ratelimit on this, at least.