From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CE5C433EF for ; Wed, 20 Apr 2022 20:58:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9F896B0071; Wed, 20 Apr 2022 16:58:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4D0F6B0073; Wed, 20 Apr 2022 16:58:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3C116B0074; Wed, 20 Apr 2022 16:58:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id A026B6B0071 for ; Wed, 20 Apr 2022 16:58:48 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60F6322771 for ; Wed, 20 Apr 2022 20:58:48 +0000 (UTC) X-FDA: 79378471536.30.AB0AA2B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 4E14D40018 for ; Wed, 20 Apr 2022 20:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+bsvCVWHr5/fnX1ncjhCQEkQ6ousz0CPAnRFlYQ9s1M=; b=jnFnisx9nTqLplB6YErEUywhH2 3WQbcCzUuwV0E/edC5Dbt2r1b0W/3iVqPeLGpsyAFLtl4d76vuD43FgvQfop0chJlxXBUwo6ERCqV uJTlGwQz6d+xURzowf4594ph7/Me1aW/piFSgE/zShu1LNrFRPeAJ4ay/QvI0/VXY8rSSeWB0BL+o bLgunz2pgvwpJax5qXoclpyFr/ep4jgqJrqQC7k56zSDYaZvAyWQfXrNe5g8tecFnI4NS57b4sHJQ h4D23xes7fHZfSFrZJguFkbjyanIgsWN/5dLg9Wv9QON1Z3G/r0nWLKqzXTCEyH+YEuzzNh/rTgB3 Z/q7tzLg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhHPO-004Reo-Az; Wed, 20 Apr 2022 20:58:42 +0000 Date: Wed, 20 Apr 2022 21:58:42 +0100 From: Matthew Wilcox To: Hailong Tu Cc: sj@kernel.org, torvalds@linux-foundation.org, gregkh@google.com, surenb@google.com, linux-mm@kvack.org, tuhailong@oppo.com, lichunpeng@oppo.com Subject: Re: [PATCH] mm/damon: Fix the timer always stays active Message-ID: References: <20220420180031.36396-1-tuhailong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220420180031.36396-1-tuhailong@gmail.com> Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jnFnisx9; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: cjrgpfzudckzm8wnjzfztakcd1mzuex9 X-Rspamd-Queue-Id: 4E14D40018 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1650488325-388420 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 02:00:31AM +0800, Hailong Tu wrote: > +static int enabled_show(char *buffer, const struct kernel_param *kp) > +{ > + return sprintf(buffer, "%c\n", enabled ? 'Y' : 'N'); > +} Why duplicate param_get_bool()?