From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA0CC433EF for ; Mon, 2 May 2022 05:16:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 317206B0072; Mon, 2 May 2022 01:16:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C7346B0073; Mon, 2 May 2022 01:16:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B61A6B0074; Mon, 2 May 2022 01:16:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 085006B0072 for ; Mon, 2 May 2022 01:16:51 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BE3A62A6A4 for ; Mon, 2 May 2022 05:16:50 +0000 (UTC) X-FDA: 79419643380.20.806ABEE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 4B51F40076 for ; Mon, 2 May 2022 05:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ayeIMCinTpq/u7MVfmi42xJboKkMgnstySy0kRIQl3s=; b=hE19F/9qpxsWERpk9uKU5lMSdb fFFl/GJlFvXMcluxy2hKTlEMRhcx9RA1bD1Xn5arLRbKr0NyNNpfoQR00PPIvdXGbKQU6P+SsRNNE RFoXnFNWswiqIHACvfLLjkBOuxQ8C3eIALXSoImHt6A7Ownp6obV3gNvtLBzUgmi7R2DG1iyvNKwg C5zZytgiS154RSSr6+EcdY10LxDp+MMVMWH+UBDawTqWiR6+MNC5/zptn7S6EjLFk2TY3vGxUIQqo QdLYpwUJIjR9rpEJhUoJMPiuCjqjTzZVSwdKvsXK+9fnavbuQpjNBQfCMb3h5L9DyG7WRU9HAZW7R TUv8cwDA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlOQA-00EY9O-54; Mon, 02 May 2022 05:16:30 +0000 Date: Mon, 2 May 2022 06:16:30 +0100 From: Matthew Wilcox To: NeilBrown Cc: Miaohe Lin , Andrew Morton , Geert Uytterhoeven , Christoph Hellwig , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MM: handle THP in swap_*page_fs() - count_vm_events() Message-ID: References: <165146746627.24404.2324091720943354711@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165146746627.24404.2324091720943354711@noble.neil.brown.name> X-Rspamd-Queue-Id: 4B51F40076 X-Stat-Signature: 54oimrzx6js1r5hykzzdernza9ebsfq6 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="hE19F/9q"; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam09 X-HE-Tag: 1651468602-428192 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 02, 2022 at 02:57:46PM +1000, NeilBrown wrote: > @@ -390,9 +392,9 @@ static void sio_read_complete(struct kiocb *iocb, long ret) > struct page *page = sio->bvec[p].bv_page; > > SetPageUptodate(page); > + count_swpout_vm_event(page); > unlock_page(page); > } > - count_vm_events(PSWPIN, sio->pages); Surely that should be count_swpIN_vm_event?