From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC3BC433F5 for ; Sun, 17 Apr 2022 08:36:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E0DD6B0072; Sun, 17 Apr 2022 04:36:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 390E66B0073; Sun, 17 Apr 2022 04:36:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2589C6B0074; Sun, 17 Apr 2022 04:36:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 128996B0072 for ; Sun, 17 Apr 2022 04:36:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DB0BB61A3C for ; Sun, 17 Apr 2022 08:36:13 +0000 (UTC) X-FDA: 79365713826.02.45ED114 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by imf10.hostedemail.com (Postfix) with ESMTP id 57DE7C0009 for ; Sun, 17 Apr 2022 08:36:13 +0000 (UTC) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ng0Nx-003jSQ-Oq; Sun, 17 Apr 2022 18:35:59 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sun, 17 Apr 2022 16:35:58 +0800 Date: Sun, 17 Apr 2022 16:35:58 +0800 From: Herbert Xu To: Catalin Marinas Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of herbert@gondor.apana.org.au designates 216.24.177.18 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 57DE7C0009 X-Stat-Signature: d49r5aorms95kh54s9kknyxjm4oidjkh X-HE-Tag: 1650184573-644603 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 17, 2022 at 09:31:09AM +0100, Catalin Marinas wrote: > > Not with my series, the non-sharing of cache lines is preserved. > kmalloc() still returns objects aligned to a cache-line. > ARCH_DMA_MINALIGN was chosen as the cover-all value for all SoCs > supported but I want to reduce the kmalloc() alignment to a cache line > size if a platform has a cache line smaller than ARCH_DMA_MINALIGN (most > arm64 SoCs have a cache line of 64 bytes rather than 128). OK, but then you don't need to play with CRYPTO_MINALIGN at all, right? All you need to do is add the padding between the Crypto API fields and the context structure, right? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt