From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F71CC433FE for ; Sat, 16 Apr 2022 05:08:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 903996B0072; Sat, 16 Apr 2022 01:08:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B3E66B0073; Sat, 16 Apr 2022 01:08:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A1AE6B0074; Sat, 16 Apr 2022 01:08:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 6AB286B0072 for ; Sat, 16 Apr 2022 01:08:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3E71C128A for ; Sat, 16 Apr 2022 05:08:49 +0000 (UTC) X-FDA: 79361562378.06.E6E3281 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 4EBF5120008 for ; Sat, 16 Apr 2022 05:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/iIo0JVr8TqpS6OeM1MMTlnanQ4ma+icA95lQhkDqAg=; b=vuqPnYaKN147QAafHsn7Xwyejz g4I0w7NWO+dMJj/kMLvTwsKf9t9ddprTrTDkT60CoTB6MnShtPbUOh72WnAhkchMIzm+PpQvU2KXT Fv/ZFNPcrUfHOEXcmrPnRnldZuosGM0QKngCmihpLBdAKnClCEJwlA2R1wJKf8lGgrjVZ5kJ1Fwx4 5c+3v3X64MnP812jEAKb+M6fqJKQctmEYDErmyXeNy0diIoo6HE6hXjpbEwuJ0a6T4AXILMYZoEfB TDz+JlzEaASoOfixBBwZ+7NHwAqvYs2s24Fb72MBgoOA/Msq916qL7MVLsTw63VQeJz2REYpiHAiB 5U89pCfg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfafr-00CGE1-O2; Sat, 16 Apr 2022 05:08:43 +0000 Date: Fri, 15 Apr 2022 22:08:43 -0700 From: Christoph Hellwig To: Luis Chamberlain Cc: Song Liu , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, akpm@linux-foundation.org, rick.p.edgecombe@intel.com, hch@infradead.org, imbrenda@linux.ibm.com Subject: Re: [PATCH v4 bpf 0/4] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP Message-ID: References: <20220415164413.2727220-1-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 9yib5t1j1azwgnrneb7a5bdxqsf9ii8b X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vuqPnYaK; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+8011bb1914c3be3034d5+6810+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8011bb1914c3be3034d5+6810+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4EBF5120008 X-HE-Tag: 1650085728-171520 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 15, 2022 at 12:05:42PM -0700, Luis Chamberlain wrote: > Looks good except for that I think this should just wait for v5.19. The > fixes are so large I can't see why this needs to be rushed in other than > the first assumptions of the optimizations had some flaws addressed here. Patches 1 and 2 are bug fixes for regressions caused by using huge page backed vmalloc by default. So I think we do need it for 5.18. The other two do look like candidates for 5.19, though.