From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73896C433F5 for ; Thu, 14 Apr 2022 11:47:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D59CD6B0071; Thu, 14 Apr 2022 07:47:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D09E06B0073; Thu, 14 Apr 2022 07:47:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD14B6B0074; Thu, 14 Apr 2022 07:47:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id AF3256B0071 for ; Thu, 14 Apr 2022 07:47:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 86A3412294D for ; Thu, 14 Apr 2022 11:47:03 +0000 (UTC) X-FDA: 79355308326.16.09574CD Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf17.hostedemail.com (Postfix) with ESMTP id 0E40D4000A for ; Thu, 14 Apr 2022 11:47:02 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id mp16-20020a17090b191000b001cb5efbcab6so9045078pjb.4 for ; Thu, 14 Apr 2022 04:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=I4Ax15jC8NnVZwecST708pDmHH3endbmV/A+QAcQDXk=; b=VTKGC4GU/h3jcWzqni4siu6RzvhvBschAcPdHBRc9lvYS1SrLmAs6BsOib0sOOC9n9 mPAvQhcYfa/SaI3Vy2SUKGJTBOWljBuEvQuqxIAS+PIYLjY+DJBtcExbtVRxxottNg22 W2fZJthM/suuUQTulb1/oCvYpDRXsmSrysTzxtK9gwzlz3hSm10tb0AcvNa2lyCC6vpd diZX7L4Ti6YA0P9RvIPxXpfBaxn0uqV0MLAwtWvyWcvEA1ARVvCZKziZUsYALiZBo3Kz h8LarTqCDePq0UgHtwIQ1s/lLxD2pnWwf2JVUpGgDtIQ6XlQ0+TQDIyHXOdLc4Q+d9MB Uruw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I4Ax15jC8NnVZwecST708pDmHH3endbmV/A+QAcQDXk=; b=8B7y8XAvuza/k9TEE5R5DMfDN1IK3yX0jVJ9Gwxt7vpgpx1plx4Cs7jyfNHrx1FXmK Xw7C5wvC3OtcnDTuXfgBGD44FC3+tGuP7cyEPithdYyaO5Ttv3bWDotA7ZFhw1ZI20GM P1+nIUKpGGNiCMCGZjljhRm3gKjxl1pjEBMOwppwUh7cRXEM8coDf2tCN25033PD96x/ KSNDMrLt9tjiRcW+Wu5aGLG6AFfpE3fVSLinNfkH2bM0/mfrGHd/cfLd6vgKPa8XZSOW FCPf5QUttow1+W9oypBsIt3zj3b0igv6N9iGsN92ROCSAHAbEFcMitrYdVqKjtB4HU9j yteQ== X-Gm-Message-State: AOAM532DtipMUEr8xkovfYKXXcEd5Kt+TDguwN5IgxC3v1Ji78ywVvKi +kBJOs/5w/Mcz1WEhdVweTE= X-Google-Smtp-Source: ABdhPJzsQvDicR9vwSUGgBVhv/HT7C7tQGE07WXlBZk/XE2dqgREhp4zs+OMYXlmvsED1JY9uw6BDw== X-Received: by 2002:a17:90a:fac:b0:1ca:5eb8:f3b2 with SMTP id 41-20020a17090a0fac00b001ca5eb8f3b2mr3340533pjz.37.1649936822021; Thu, 14 Apr 2022 04:47:02 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id g15-20020aa7818f000000b00505ce2e4640sm1959117pfi.100.2022.04.14.04.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 04:47:00 -0700 (PDT) Date: Thu, 14 Apr 2022 20:46:54 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Christoph Lameter Cc: Vlastimil Babka , Marco Elver , Matthew WilCox , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 23/23] mm/sl[au]b: check if large object is valid in __ksize() Message-ID: References: <20220414085727.643099-1-42.hyeyoo@gmail.com> <20220414085727.643099-24-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: f9tobzj9h9eadnbsf3qpe9kkh78o4yjj Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VTKGC4GU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0E40D4000A X-HE-Tag: 1649936822-361440 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 11:58:01AM +0200, Christoph Lameter wrote: > On Thu, 14 Apr 2022, Hyeonggon Yoo wrote: > > > If address of large object is not beginning of folio or size of > > the folio is too small, it must be invalid. Return zero in such cases. > > This looks like a slab usage error on the part of the caller that would > benefit from a kernel log entry. A warning or an error? I think a WARN_ON() would be sufficient. here, will do in v3. Thanks! -- Thanks, Hyeonggon