From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6484CC433FE for ; Wed, 13 Apr 2022 07:55:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91B7E6B0072; Wed, 13 Apr 2022 03:55:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A49A6B0073; Wed, 13 Apr 2022 03:55:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71D566B0074; Wed, 13 Apr 2022 03:55:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 5F6D16B0072 for ; Wed, 13 Apr 2022 03:55:53 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 23A7320590 for ; Wed, 13 Apr 2022 07:55:53 +0000 (UTC) X-FDA: 79351096986.03.6ECEC1E Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf11.hostedemail.com (Postfix) with ESMTP id 028AE40003 for ; Wed, 13 Apr 2022 07:55:51 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id h23-20020a17090a051700b001c9c1dd3acbso1296077pjh.3 for ; Wed, 13 Apr 2022 00:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BQqO6TV4r8xYP9ll759EC2sYrn2d+Lu4nF7LGYI0lzg=; b=KU/UgTioCBDtpq4qjf6dMXRyT2VYVzHvUI2rtjT+3/lmuvpT9Tx4AQFa3gXtjSstY0 k/F2rY9bQfccugZOu1B6ypVL9C5eebvRoEtF3oGEMz/T1E5tE5ywAR7ivJP+/oLEdVy+ /kegDWfGJBmXWbj9tQEIL43g0Z+6Z4qmnyxvh/u1dTglCe3E6ASXc7zJSZ8/SKQj5Z6Y nnm1ZLXzrtLW0ggtmmP2FAYJ8RgPAAEIzRZfUj3fFs1Xfstkh98gVDryicEfbyzCr8x2 VZ+h7d77ST7eGufr/e5mMhoFwIjAoCwrEpNwnCINgXbbfeQ5P9ofD9KD9BZ6cwr8Ck0e bN3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BQqO6TV4r8xYP9ll759EC2sYrn2d+Lu4nF7LGYI0lzg=; b=8GBx7hgGfEbywTCNrT3DA4ns8Fgi0RUl7948hv32J7cDLaKL0sp9Xv0BuCm/EKCJ2J IwDV/xAS6wHc99Qh0toM4y66Q7nftgwt5oQDHPxoQ49Dx5rf7KI+8Gf+9FJSZo0/mkEW iRth/AIYIh0BPJW5CaSh5+hYHAhAefb5fd7WXL9nyGI0kdBtXj5tTy5jj8YuzroXHR0w ck4PCMU7xPyLBt08zmzhjqZANiAGlhtnLl4+XV8rZ7g2U6+pjM74bnjrZqQhY0b/6uT5 D56GfawUdAHIgFglA1bUsoTWQ38yZOmzDKoNSuOWVwKTWW3XoHRzdY5tMrr4YIGy+iE2 gpwg== X-Gm-Message-State: AOAM5316FcBsyhjty5VtuTZ/ukzZJQMpkxtAIDkSqB6wXDMTY6oBmvqN sculAq1JPpgE2X5NTczSZW54VA== X-Google-Smtp-Source: ABdhPJwH5lYT3GdpeVp09+OhXkHwPzhgrjzToSYi/WAqKGA6TIRQRz6tNAt4M/yyEHcfQ9HI8dU7aA== X-Received: by 2002:a17:903:18e:b0:158:7255:4c12 with SMTP id z14-20020a170903018e00b0015872554c12mr11797050plg.123.1649836550615; Wed, 13 Apr 2022 00:55:50 -0700 (PDT) Received: from localhost ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id k3-20020a056a00168300b004f7e60da26csm42132968pfc.182.2022.04.13.00.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 00:55:50 -0700 (PDT) Date: Wed, 13 Apr 2022 15:55:47 +0800 From: Muchun Song To: Peng Liu Cc: mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] hugetlb: Fix return value of __setup handlers Message-ID: References: <20220413032915.251254-1-liupeng256@huawei.com> <20220413032915.251254-4-liupeng256@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220413032915.251254-4-liupeng256@huawei.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 028AE40003 X-Stat-Signature: zx6hquxqtkqkc8qqxcuqsbgi3q3xd9fw Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="KU/UgTio"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-HE-Tag: 1649836551-85308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000069, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 13, 2022 at 03:29:14AM +0000, Peng Liu wrote: > When __setup() return '0', using invalid option values causes the > entire kernel boot option string to be reported as Unknown. Hugetlb > calls __setup() and will return '0' when set invalid parameter > string. > > The following phenomenon is observed: > cmdline: > hugepagesz=1Y hugepages=1 > dmesg: > HugeTLB: unsupported hugepagesz=1Y > HugeTLB: hugepages=1 does not follow a valid hugepagesz, ignoring > Unknown kernel command line parameters "hugepagesz=1Y hugepages=1" > > Since hugetlb will print warning/error information before return for > invalid parameter string, just use return '1' to avoid print again. > Can't return -EINVAL? It is weird to return 1 on failure. Thanks.